Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mito): mv mito2 request #2086

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Aug 3, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR only moves positions of request mod and struct SkippedFields.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag evenyag marked this pull request as ready for review August 3, 2023 03:14
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #2086 (11b47b9) into develop (90b2200) will decrease coverage by 0.29%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2086      +/-   ##
===========================================
- Coverage    85.15%   84.87%   -0.29%     
===========================================
  Files          677      677              
  Lines       106689   106689              
===========================================
- Hits         90849    90550     -299     
- Misses       15840    16139     +299     

@evenyag evenyag requested review from v0y4g3r and waynexia August 3, 2023 03:31
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Aug 3, 2023
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weather report: 🌧️🌊 in Beijing and GreptimeDB

Merged via the queue into GreptimeTeam:develop with commit fdd4929 Aug 3, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* refactor: mv request mod to crate level

* refactor: mv SkippedFields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants