-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mito): preparation to implementing write #2085
Merged
evenyag
merged 20 commits into
GreptimeTeam:develop
from
evenyag:feat/mito2-write-request
Aug 4, 2023
Merged
feat(mito): preparation to implementing write #2085
evenyag
merged 20 commits into
GreptimeTeam:develop
from
evenyag:feat/mito2-write-request
Aug 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenyag
changed the title
feat(mito): preparation to implement write
feat(mito): preparation to implementing write
Aug 3, 2023
evenyag
force-pushed
the
feat/mito2-write-request
branch
from
August 3, 2023 06:48
c3883d2
to
4413b4a
Compare
2 tasks
Codecov Report
@@ Coverage Diff @@
## develop #2085 +/- ##
===========================================
- Coverage 85.23% 84.63% -0.61%
===========================================
Files 683 686 +3
Lines 106960 107455 +495
===========================================
- Hits 91171 90948 -223
- Misses 15789 16507 +718 |
waynexia
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No test so I can only choose to believe the great coder
killme2008
approved these changes
Aug 3, 2023
Co-authored-by: dennis zhuang <[email protected]>
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* refactor: move request mod * feat: add mutation * feat: add handle_write mod * feat: one mutation at a time * feat: handle write requests * feat: validate schema * refactor: move schema check to write request * feat: add convert value * feat: fill default values * chore: remove comments * feat: remove code * feat: remove code * feat: buf requests * style: fix clippy * refactor: rename check functions * chore: fix compile error * chore: Revert "feat: remove code" This reverts commit 6516597. * chore: Revert "feat: remove code" This reverts commit 5f2b790. * chore: upgrade greptime-proto * chore: Update comment Co-authored-by: dennis zhuang <[email protected]> --------- Co-authored-by: dennis zhuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR adds utilities for implementing write for mito2, which mainly contains conversion between protobuf types and some validations.
proto_util
mod to help convert types between db and protohandle_write_requests
. It useRegionWriteCtx
to batch requests and maintains sequencesWriteRequest
.WriteRequest
Checklist
Refer to a related PR or issue link (optional)