fix(build): disable -Wconversion to make compilation easier

GothicKit · Apr 29, 2024 · 8b8b4ef · 8b8b4ef
1 parent ca42153
commit 8b8b4ef
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Performance.c b/src/Performance.c
@@ -417,7 +417,7 @@ static float lerp(float x, float start, float end) {
 // See https://documentation.help/DirectMusic/dmusiostylenote.htm
 static uint32_t DmPerformance_convertIoTimeRange(uint8_t range) {
 	uint32_t result = 0;
-	if (0 <= range && range <= 190) {
+	if (range <= 190) {
 		result = range;
 	} else if (191 <= range && range <= 212) {
 		result = ((range - 190) * 5) + 190;

diff --git a/support/BuildSupport.cmake b/support/BuildSupport.cmake
@@ -58,7 +58,7 @@ endfunction()
 ##   COMPILE(list): A list containing the compiler play_mode_flags
 ##   LINK(list): A list containing the linker play_mode_flags
 function(bs_internal_select_cflags_gcc SANITIZERS COMPILE LINK)
-    list(APPEND _INTERNAL_FLAGS "-Wall" "-Wextra" "-Werror" "-Wconversion" "-Wshadow" "-Wpedantic" "-fPIC" "-flto")
+    list(APPEND _INTERNAL_FLAGS "-Wall" "-Wextra" "-Werror" "-Wshadow" "-Wpedantic" "-fPIC" "-flto")
 
     if (CMAKE_BUILD_TYPE MATCHES "^Debug" AND ${SANITIZERS} AND NOT WIN32)
         list(APPEND _INTERNAL_FLAGS "-fsanitize=address" "-fsanitize=undefined" "-fsanitize=leak")