[#94] fix(ArchiveAscii): skip spaces without memory alloc

* fix TODO - skip spaces without memory alloc * fixup formatting --------- Co-authored-by: Luis Michaelis <[email protected]>
GothicKit · Aug 2, 2024 · 7121a33 · 7121a33
1 parent f942cf2
commit 7121a33
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/src/archive/ArchiveAscii.cc b/src/archive/ArchiveAscii.cc
@@ -71,12 +71,17 @@ namespace zenkit {
 		auto line = read->read_line(true);
 
 		// Compatibility fix for binary data in ASCII archives.
-		// TODO: Optimize using `find_if`!
-		while (std::isspace(static_cast<unsigned char>(line[0]))) {
-			line = line.substr(1);
+		std::string_view view = line;
+		size_t spaces_count = 0;
+		for (; spaces_count < view.size() && std::isspace(static_cast<unsigned char>(view[spaces_count]));
+		     ++spaces_count)
+			;
+
+		if (spaces_count > 0) {
+			view.remove_prefix(spaces_count);
 		}
 
-		if (line != "[]") {
+		if (view != "[]") {
 			read->seek(static_cast<ssize_t>(mark), Whence::BEG);
 			return false;
 		}