-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homepage layout proposal #116
Homepage layout proposal #116
Conversation
I think the PR is ready, I would also provide polish translation, just let me know if the layout is good enough |
Additionally, the position of the links isn't synced to the bottom, I once helped out with this via extra CSS, should be a small fix 🤔 EDIT: Found my answer .md-typeset .grid.cards > ul > li {
display: flex;
flex-direction: column;
outline: 1px solid green;
}
.grid.cards li p:last-child {
display: flex;
flex-grow: 5; /* Probably 2 would be enough, as the grids shouldn't hold too much text to begin with, but to be safe I set it to 5 */
outline: 1px solid red;
}
.grid.cards li p:last-child a {
align-self: flex-end;
} Please test if it still works and and include it in No need to add me as co-author 👍 |
Otherwise the layout and content seems fine, you can start translating imo 👌 |
I have already told that i hate css, but i will just copy-paste it and see if everything works |
@kamilkrzyskow Is that what you wanted to achieve? |
I am currently connected with my PC by remote desktop so the graphics is a bit deformed |
The changes LGTM, good CSS placement 👍 , the |
Please also add this firefox_l7YMFz4pUW.mp4.grid.cards li > p:first-child > strong {
vertical-align: middle;
} |
* Homepage layout proposal * Fix: Change repository link to gmc * Change text in Repository grid card * Zengin index concept * Fix links * Fix the position of links in grid cards * Change the link in index and spelling mistake in zengin/index * Polish translation for zengin/index.md * Fix grid cards css * Fix tranlsation of zengin/index * Polish tranlsation of the main index.md * Fix english name in zengin/index translation
* Homepage layout proposal * Fix: Change repository link to gmc * Change text in Repository grid card * Zengin index concept * Fix links * Fix the position of links in grid cards * Change the link in index and spelling mistake in zengin/index * Polish translation for zengin/index.md * Fix grid cards css * Fix tranlsation of zengin/index * Polish tranlsation of the main index.md * Fix english name in zengin/index translation
No description provided.