Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage layout proposal #116

Merged
merged 12 commits into from
Jun 7, 2024

Conversation

muczc1wek
Copy link
Contributor

No description provided.

docs/index.md Outdated Show resolved Hide resolved
@muczc1wek
Copy link
Contributor Author

obraz

@muczc1wek
Copy link
Contributor Author

obraz

docs/index.md Outdated Show resolved Hide resolved
@muczc1wek
Copy link
Contributor Author

I think the PR is ready, I would also provide polish translation, just let me know if the layout is good enough

@muczc1wek muczc1wek marked this pull request as ready for review June 6, 2024 18:35
@muczc1wek muczc1wek requested a review from kamilkrzyskow June 6, 2024 18:43
docs/zengin/index.md Outdated Show resolved Hide resolved
@kamilkrzyskow
Copy link
Collaborator

kamilkrzyskow commented Jun 7, 2024

Additionally, the position of the links isn't synced to the bottom, I once helped out with this via extra CSS, should be a small fix 🤔

EDIT: Found my answer

.md-typeset .grid.cards > ul > li {
  display: flex;
  flex-direction: column;
  outline: 1px solid green;
}
.grid.cards li p:last-child {
  display: flex;
  flex-grow: 5; /* Probably 2 would be enough, as the grids shouldn't hold too much text to begin with, but to be safe I set it to 5 */
  outline: 1px solid red;	
}
.grid.cards li p:last-child a {
  align-self: flex-end;
}

Please test if it still works and and include it in extra.css with proper formatting, if no previous regions match this category add some general region page content etc. ✌️

No need to add me as co-author 👍

@kamilkrzyskow
Copy link
Collaborator

Otherwise the layout and content seems fine, you can start translating imo 👌

@muczc1wek
Copy link
Contributor Author

I have already told that i hate css, but i will just copy-paste it and see if everything works

docs/index.md Outdated Show resolved Hide resolved
@muczc1wek
Copy link
Contributor Author

@kamilkrzyskow Is that what you wanted to achieve?
obraz

@kamilkrzyskow
Copy link
Collaborator

kamilkrzyskow commented Jun 7, 2024

Yes, the links are at the bottom even if the content isn't as big as in the other column.
Everything is "unified" for lack of a better word.

But why is the font pixelated 🤔
image

@muczc1wek
Copy link
Contributor Author

I am currently connected with my PC by remote desktop so the graphics is a bit deformed

@kamilkrzyskow
Copy link
Collaborator

The changes LGTM, good CSS placement 👍 , the outline comment didn't have to be there though.
I forgot to remove it from the answer, this was for me to figure this solution out 😅

@kamilkrzyskow
Copy link
Collaborator

Please also add this

firefox_l7YMFz4pUW.mp4
.grid.cards li > p:first-child > strong {
  vertical-align: middle;
}

docs/zengin/index.pl.md Outdated Show resolved Hide resolved
docs/zengin/index.pl.md Outdated Show resolved Hide resolved
@kamilkrzyskow kamilkrzyskow merged commit 00dd163 into Gothic-Modding-Community:dev Jun 7, 2024
1 check passed
kamilkrzyskow pushed a commit to kamilkrzyskow/gmc that referenced this pull request Jun 11, 2024
* Homepage layout proposal

* Fix: Change repository link to gmc

* Change text in Repository grid card

* Zengin index concept

* Fix links

* Fix the position of links in grid cards

* Change the link in index and spelling mistake in zengin/index

* Polish translation for zengin/index.md

* Fix grid cards css

* Fix tranlsation of zengin/index

* Polish tranlsation of the main index.md

* Fix english name in zengin/index translation
muczc1wek added a commit to muczc1wek/gmc that referenced this pull request Jun 27, 2024
* Homepage layout proposal

* Fix: Change repository link to gmc

* Change text in Repository grid card

* Zengin index concept

* Fix links

* Fix the position of links in grid cards

* Change the link in index and spelling mistake in zengin/index

* Polish translation for zengin/index.md

* Fix grid cards css

* Fix tranlsation of zengin/index

* Polish tranlsation of the main index.md

* Fix english name in zengin/index translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants