Feature: React Bidding Block #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-telsan
force-pushed
the
nt/93-react-init
branch
from
8d6f9d6 to
c9e8c0e
Compare
nick-telsan
requested review from
cwmanning,
solomonhawk,
nathan-schmidt-viget and
bd-viget
nick-telsan
commented
Dec 21, 2023
nathan-schmidt-viget
force-pushed
the
ns/91-auction-style
branch
from
523a1fc to
7099433
Compare
Merged
bd-viget
reviewed
Dec 21, 2023
There was a problem hiding this comment.
Ran through and just made a few quick comments/notes. So excited to see this coming together! There are a lot of conflicting things in this PR and Nathan's PR. Just want to make sure we don't break everything or have duplicates of stuff after both of these are ready to go.
| 1. `root`: Run at project root. | ||
| 2. `client-mu-plugins/goodbids`: GoodBids MU Plugin | ||
|
|
||
| Alternatively, running `bin/install` will install all composer and npm dependencies. |
There was a problem hiding this comment.
I'll need to go through and test this, but I'm fine just having 1 way to install scripts/dependencies. If this works, we can get rid of the docs to install them separately.
nick-telsan
force-pushed
the
nt/93-react-init
branch
2 times, most recently
from
47ce721 to
4eedc25
Compare
nathan-schmidt-viget
force-pushed
the
ns/91-auction-style
branch
from
65bae11 to
864a64a
Compare
nathan-schmidt-viget
force-pushed
the
ns/91-auction-style
branch
2 times, most recently
from
1d95d79 to
8763c4f
Compare
nick-telsan
force-pushed
the
nt/93-react-init
branch
4 times, most recently
from
d5dcc90 to
4f38402
Compare
nathan-schmidt-viget
approved these changes
Jan 3, 2024
bd-viget
reviewed
Jan 4, 2024
nick-telsan
force-pushed
the
nt/93-react-init
branch
3 times, most recently
from
a79b16f to
019dcd5
Compare
nick-telsan
force-pushed
the
nt/93-react-init
branch
from
5c09b82 to
c230e67
Compare
- Adds prettier - Adds lint-staged and husky - Adds bin scripts - Adds initial react app
- Uses WP formatting patterns - Adds bin/start-vite - Moves React app to main.tsx temporarily
- Removes toplevel package.json - Moves configuration files down into the goodbids plugin - Adjusts config to handle new structure
- Adds packages for WP Script blocks - Adjust TS Config
nick-telsan
force-pushed
the
nt/93-react-init
branch
from
1445722 to
6348802
Compare
nick-telsan
added a commit
that referenced
this pull request
Jan 9, 2024
* [#93] React Init - Adds prettier - Adds lint-staged and husky - Adds bin scripts - Adds initial react app * [#93] React Init WordPress Block Changes (#153) - Custom React Block for Bidding - Adds packages for WP Script blocks - Adjust TS Config * [#94] Metrics but WP (#155) - Adds driver and metrics component - Adjusts Tailwind content paths - Adds inputs for new components - Adds script to handle components in dev mode - Moves metrics into the WP block * [#95] Countdown Timer (#148) - Adds countdown timer component and functions - Adjusts initial state for demo - Adjusts font styles - Fixes gitignore build * [#96] Bid Button (#149) - Adds clsx - Adds bid button * [#97] Free Bids (#150) - Adds free bids button - Adds demo data * [#100] Participation (#151) - Adds participation component * [#101] Free Bids (#152) - Adds free bids promo - Adds temporary hand icon * [#140] Websocket Connection (#167) - Installs zod and zustand - Adds attributes to block.json - Adds auction store - Adds types - Changes initial state to data attributes - Adjusts use of data attributes and useAuction - Adds websocket connection - Hardcodes WS URL for now.
nick-telsan
added a commit
that referenced
this pull request
Jan 9, 2024
* [#93] React Init - Adds prettier - Adds lint-staged and husky - Adds bin scripts - Adds initial react app * [#93] React Init WordPress Block Changes (#153) - Custom React Block for Bidding - Adds packages for WP Script blocks - Adjust TS Config * [#94] Metrics but WP (#155) - Adds driver and metrics component - Adjusts Tailwind content paths - Adds inputs for new components - Adds script to handle components in dev mode - Moves metrics into the WP block * [#95] Countdown Timer (#148) - Adds countdown timer component and functions - Adjusts initial state for demo - Adjusts font styles - Fixes gitignore build * [#96] Bid Button (#149) - Adds clsx - Adds bid button * [#97] Free Bids (#150) - Adds free bids button - Adds demo data * [#100] Participation (#151) - Adds participation component * [#101] Free Bids (#152) - Adds free bids promo - Adds temporary hand icon * [#140] Websocket Connection (#167) - Installs zod and zustand - Adds attributes to block.json - Adds auction store - Adds types - Changes initial state to data attributes - Adjusts use of data attributes and useAuction - Adds websocket connection - Hardcodes WS URL for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming Soon!
This is a feature branch for the React work since there are a lot of moving parts. We'll have a more descriptive PR description once we finish merging in all of those pieces.
PRs
Issues