[#91] Auction style #107

nathan-schmidt-viget · 2023-12-20T18:32:29Z

Summary

This does the style pass of the Auction page.
Sets up Vite and Tailwind in the plugin (very basic setup). @nick-telsan has the full set up with React, linter, and Prettier in his PR #115.

This is a simple pass on the mobile view, we may need to do more styling later. There are a few other items in the theme that need to be pull into TW, as well as some cleanup in the theme for TW. But that will be in another PR in order to get this PR out for Friday's client work demo.

Issues

Style the Auction page #91

Testing Instructions

Go to an auction page. You can create a new one or use one that you already have set up.
Make sure the reward product that is linked to the auction at a few images.
Make sure it looks like the screenshots for desktop and mobile.

Screenshots

Desktop	Mobile

client-mu-plugins/goodbids/blocks/reward-product/block.css

client-mu-plugins/goodbids/blocks/reward-product-gallery/block.css

client-mu-plugins/goodbids/src/helpers.php

nick-telsan · 2023-12-21T16:09:35Z

postcss.config.js

export default {
  plugins: {
    tailwindcss: {},
    autoprefixer: {},
  },
};

clatwell · 2023-12-21T16:15:05Z

cc @bd-viget ☝️

nathan-schmidt-viget · 2023-12-21T16:55:08Z

@nick-telsan nice ya I did not get too far with setting up TW thanks for flagging that!

client-mu-plugins/goodbids/blocks/bid-now/block.php

client-mu-plugins/goodbids/blocks/reward-product-gallery/block.css

client-mu-plugins/goodbids/package.json

client-mu-plugins/goodbids/src/assets/css/main.css

client-mu-plugins/goodbids/tailwind.config.js

themes/goodbids-main/theme.json

nick-telsan · 2023-12-21T21:59:30Z

I think we'll also need to update the .circleci/config.yml, but this might take a little bit of tweaking on my end. I can add it to my PR tomorrow, but this one won't build unless we add this.

    steps:
      - checkout
      - run: echo "Building..."
      - run: echo "${ACF_DEVELOP}" >> ./client-mu-plugins/goodbids/auth.json
      - run: echo "$(< ./client-mu-plugins/goodbids/auth.json)"
      - run: cd client-mu-plugins/goodbids && npm ci
      - run: cd client-mu-plugins/goodbids && npm run build
      - run: cd client-mu-plugins/goodbids && composer install --verbose

client-mu-plugins/goodbids/.gitignore

.gitignore

bd-viget

Ok, I think I've gone through everything from a code perspective. I'm going to pull down this branch and test everything out next. Nice job getting all this working!! I'm so pumped!

client-mu-plugins/goodbids/blocks/auction-metrics-general/render.php

client-mu-plugins/goodbids/src/classes/Frontend/Vite.php

client-mu-plugins/goodbids/tailwind.config.js

client-mu-plugins/goodbids/vite.config.js

client-mu-plugins/goodbids/src/classes/Frontend/Vite.php

bd-viget

Hey @nathan-schmidt-viget, thanks for your patience with me to follow up on this review. Just a few stragglers to address, and I think this'll be good to go!

client-mu-plugins/goodbids/.gitignore

client-mu-plugins/goodbids/blocks/auction-metrics-general/render.php

client-mu-plugins/goodbids/src/classes/Frontend/Vite.php

nathan-schmidt-viget · 2024-01-03T00:17:49Z

@bd-viget got those small edits in. I have re-requested a review.

bd-viget

Very minor formatting notes, but again, don't want be a blocker, so approved after that!! Thanks again for your patience!

bd-viget · 2024-01-03T06:00:54Z

client-mu-plugins/goodbids/blocks/auction-metrics-general/render.php

+	<div class="flex flex-col text-center">
+		<p class="m-0 uppercase font-thin has-x-small-font-size"><?php esc_html_e( 'Auction Goal', 'goodbids' ); ?></p>
+		<?php


Looks like we lost the indention formatting here.

bd-viget · 2024-01-03T06:01:02Z

client-mu-plugins/goodbids/blocks/auction-metrics-general/render.php

 				);
 			?>
-		</div>
+	</div>


bd-viget · 2024-01-03T06:01:13Z

client-mu-plugins/goodbids/blocks/auction-metrics-general/render.php

+	<div class="flex flex-col text-center">
+		<p class="m-0 uppercase font-thin has-x-small-font-size"><?php esc_html_e( 'Auction Goal', 'goodbids' ); ?></p>
+		<?php


bd-viget · 2024-01-03T06:01:20Z

client-mu-plugins/goodbids/blocks/auction-metrics-general/render.php

 				printf(
 					'<p class="m-1 font-extrabold">%s</p>',
 					wp_kses_post( wc_price( $estimated_value ) )
 				);
 			?>
-		</div>
+	</div>


bd-viget · 2024-01-03T06:01:29Z

client-mu-plugins/goodbids/blocks/auction-metrics-general/render.php

-		<div class="flex flex-col text-center">
-			<p class="m-0 uppercase font-thin has-x-small-font-size"><?php esc_html_e( 'Auction Goal', 'goodbids' ); ?></p>
-			<?php
+	<div class="flex flex-col text-center">


Lastly here.

bd-viget · 2024-01-03T06:01:43Z

client-mu-plugins/goodbids/blocks/auction-metrics-general/render.php

 				printf(
 					'<p class="m-1 font-extrabold">%s</p>',
 					wp_kses_post( wc_price( $expected_high_bid ) )
 				);
 			?>
-		</div>
+	</div>


Lastly here-final-final-v3

nathan-schmidt-viget · 2024-01-03T14:51:27Z

@bd-viget looks like php linter quit working after I updated my computer over the break. I am going to merge this and then fix the spacing in another PR once I fix the linting today.

nathan-schmidt-viget requested review from bd-viget, joshuapease and nick-telsan December 20, 2023 18:32

nathan-schmidt-viget force-pushed the ns/91-auction-style branch 3 times, most recently from c7ee40c to 985d450 Compare December 20, 2023 18:36

nathan-schmidt-viget commented Dec 20, 2023

View reviewed changes

client-mu-plugins/goodbids/blocks/reward-product/block.css Outdated Show resolved Hide resolved

nathan-schmidt-viget commented Dec 20, 2023

View reviewed changes

client-mu-plugins/goodbids/blocks/reward-product-gallery/block.css Outdated Show resolved Hide resolved

nick-telsan reviewed Dec 20, 2023

View reviewed changes

client-mu-plugins/goodbids/src/helpers.php Outdated Show resolved Hide resolved

nick-telsan mentioned this pull request Dec 21, 2023

Create Auction React App in GoodBids repo #93

Closed

nathan-schmidt-viget force-pushed the ns/91-auction-style branch from 523a1fc to 7099433 Compare December 21, 2023 20:06

nathan-schmidt-viget marked this pull request as ready for review December 21, 2023 21:36

nathan-schmidt-viget force-pushed the ns/91-auction-style branch from 7ba449a to e506ae4 Compare December 21, 2023 21:44

nathan-schmidt-viget commented Dec 21, 2023

View reviewed changes

client-mu-plugins/goodbids/blocks/bid-now/block.php Show resolved Hide resolved

nathan-schmidt-viget commented Dec 21, 2023

View reviewed changes

client-mu-plugins/goodbids/blocks/reward-product-gallery/block.css Show resolved Hide resolved

nathan-schmidt-viget commented Dec 21, 2023

View reviewed changes

client-mu-plugins/goodbids/package.json Show resolved Hide resolved

nathan-schmidt-viget commented Dec 21, 2023

View reviewed changes

client-mu-plugins/goodbids/src/assets/css/main.css Show resolved Hide resolved

nathan-schmidt-viget commented Dec 21, 2023

View reviewed changes

client-mu-plugins/goodbids/tailwind.config.js Show resolved Hide resolved

nathan-schmidt-viget commented Dec 21, 2023

View reviewed changes

themes/goodbids-main/theme.json Outdated Show resolved Hide resolved

bd-viget reviewed Dec 21, 2023

View reviewed changes

client-mu-plugins/goodbids/.gitignore Show resolved Hide resolved

bd-viget reviewed Dec 21, 2023

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

bd-viget suggested changes Dec 21, 2023

View reviewed changes

joshuapease approved these changes Dec 21, 2023

View reviewed changes

client-mu-plugins/goodbids/vite.config.js Outdated Show resolved Hide resolved

bd-viget mentioned this pull request Dec 21, 2023

Feature: React Bidding Block #115

Merged

nathan-schmidt-viget requested a review from bd-viget December 22, 2023 17:00

nathan-schmidt-viget commented Dec 22, 2023

View reviewed changes

client-mu-plugins/goodbids/src/classes/Frontend/Vite.php Show resolved Hide resolved

nathan-schmidt-viget force-pushed the ns/91-auction-style branch 2 times, most recently from 65bae11 to 864a64a Compare December 22, 2023 18:13

nathan-schmidt-viget and others added 15 commits January 2, 2024 13:47

[#91] adding classes and style

d817c2a

[#91] styling the auction page

889b004

[#91] setting up vite

03ca0b7

[#91] setting up asset helper

819bfb1

[#91] Setting up tailwind

e5b1a23

[#91] Dropped in Vite class (WIP)

1f7c004

Updated package.json, vite and tw configs

425cfd7

[#91] WIP - Vite + TW

c642143

[#91] Couple of bug fixes

c5d6846

[#91] adding vite options and postcss

30fc716

[#91] styling the auction page

596e2e6

[#91] cleaning up style and fixing a few things

de91b31

[#91] undoing some unused code

c29a52b

[#91] fixing PR notes

c9eac2a

[#91] fixing html output

571a511

nathan-schmidt-viget force-pushed the ns/91-auction-style branch from 5c4b5be to 571a511 Compare January 2, 2024 20:48

bd-viget suggested changes Jan 2, 2024

View reviewed changes

nathan-schmidt-viget mentioned this pull request Jan 2, 2024

[#127] Nonprofit Interest Form #134

Merged

nathan-schmidt-viget force-pushed the ns/91-auction-style branch from 32815ba to 1d95d79 Compare January 3, 2024 00:05

[#91] Fixing small edits in PR

8763c4f

nathan-schmidt-viget force-pushed the ns/91-auction-style branch from 1d95d79 to 8763c4f Compare January 3, 2024 00:14

nathan-schmidt-viget requested a review from bd-viget January 3, 2024 00:15

bd-viget approved these changes Jan 3, 2024

View reviewed changes

nathan-schmidt-viget merged commit c4744e5 into main Jan 3, 2024
1 check passed

nathan-schmidt-viget deleted the ns/91-auction-style branch January 3, 2024 14:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#91] Auction style #107

[#91] Auction style #107

nathan-schmidt-viget commented Dec 20, 2023 •

edited

Loading

nick-telsan commented Dec 21, 2023

clatwell commented Dec 21, 2023

nathan-schmidt-viget commented Dec 21, 2023

nick-telsan commented Dec 21, 2023

bd-viget left a comment

bd-viget left a comment

nathan-schmidt-viget commented Jan 3, 2024

bd-viget left a comment

bd-viget Jan 3, 2024

bd-viget Jan 3, 2024

bd-viget Jan 3, 2024

bd-viget Jan 3, 2024

bd-viget Jan 3, 2024

bd-viget Jan 3, 2024

nathan-schmidt-viget commented Jan 3, 2024

[#91] Auction style #107

[#91] Auction style #107

Conversation

nathan-schmidt-viget commented Dec 20, 2023 • edited Loading

Summary

Issues

Testing Instructions

Screenshots

nick-telsan commented Dec 21, 2023

clatwell commented Dec 21, 2023

nathan-schmidt-viget commented Dec 21, 2023

nick-telsan commented Dec 21, 2023

bd-viget left a comment

Choose a reason for hiding this comment

bd-viget left a comment

Choose a reason for hiding this comment

nathan-schmidt-viget commented Jan 3, 2024

bd-viget left a comment

Choose a reason for hiding this comment

bd-viget Jan 3, 2024

Choose a reason for hiding this comment

bd-viget Jan 3, 2024

Choose a reason for hiding this comment

bd-viget Jan 3, 2024

Choose a reason for hiding this comment

bd-viget Jan 3, 2024

Choose a reason for hiding this comment

bd-viget Jan 3, 2024

Choose a reason for hiding this comment

bd-viget Jan 3, 2024

Choose a reason for hiding this comment

nathan-schmidt-viget commented Jan 3, 2024

nathan-schmidt-viget commented Dec 20, 2023 •

edited

Loading