[#78] setting up Goodbids main theme #110

nathan-schmidt-viget · 2023-12-20T21:12:09Z

Summary

This sets up the main Goodbids theme which is a copy of WP Twenty Twenty-Four theme. 99% of this is copied files, I will flag the files I edited.

All of the base styles are removed from the nonprofit site and moved into the main theme.

I added the plum and the two pink as accent colors to the main site as the originally Twenty Twenty-Four accent colors did not go with the GB green, but we needed those accent colors for some core patterns. May not be a big deal if we remove the core patterns, but does not hurt to have those colors available to the main site editor.

Issues

Network Site: GoodBids Theme Style #78

Testing Instructions

Go to the Network Admin -> Themes and click "Network Enable" if not already turned on.
Go to the GoodBids Main site Dashboard.
- Appearance -> Themes and activate the GoodBids Main theme.
- Click on Appearance -> Editor and make sure the new main theme looks like the one in the screenshot (green bg).
Go to a nonprofit site and make sure the GoodBids NonProfit looks the same as it did before (white bg).

Screenshots

Colors	Theme

nathan-schmidt-viget · 2023-12-20T21:12:51Z

themes/goodbids-main/functions.php

+/**
+ * Disable remote block patterns.
+ */
+add_filter( 'should_load_remote_block_patterns', '__return_false' );


Remove remote patterns.

nathan-schmidt-viget · 2023-12-20T21:14:29Z

themes/goodbids-main/screenshot.png

Custom screenshot for the main theme

nathan-schmidt-viget · 2023-12-20T21:14:48Z

themes/goodbids-main/style.css

Update style.css

nathan-schmidt-viget · 2023-12-20T21:15:46Z

themes/goodbids-nonprofit/inc/patterns.php

+/**
+ * Disable remote block patterns.
+ */
+add_filter( 'should_load_remote_block_patterns', '__return_false' );
+
+


Disable remove patterns.

Since we are doing this in the parent theme, we shouldn't need to do this in the child theme.

Yes, that is correct.

nathan-schmidt-viget · 2023-12-20T21:16:41Z

themes/goodbids-main/theme.json

All the colors are updated and any custom padding or style for buttons is moved into the main and removed from the child site.

nathan-schmidt-viget · 2023-12-20T21:17:16Z

themes/goodbids-nonprofit/style.css

Update the nonprofit site to be a child of the goodbids main theme.

nathan-schmidt-viget · 2023-12-20T21:18:38Z

themes/goodbids-nonprofit/theme.json

Removed most of the custom style in the child theme as they are now in the main theme. The only thing we had to keep is the colors. If I removed the colors from the child theme they all default to black/white, which is not what we want.

nathan-schmidt-viget · 2023-12-20T21:22:07Z

@bd-viget and @nathanlong I have made notes to all the files that I have edited, which should make it easier for you.

The rest are a copy of the twenty twenty-four theme. Some of these templates and patterns we may not need, but once the pages are set up we can go through here and remove all of them that we don't need.

bd-viget

Amazing job going through all the Twenty Twenty-Four theme files! You nailed getting all the references updated. Requested a few small changes, and had some questions about other stuff.

themes/goodbids-main/style.css

themes/goodbids-main/readme.txt

bd-viget · 2023-12-20T23:01:25Z

themes/goodbids-nonprofit/inc/patterns.php

+/**
+ * Disable remote block patterns.
+ */
+add_filter( 'should_load_remote_block_patterns', '__return_false' );
+
+


Since we are doing this in the parent theme, we shouldn't need to do this in the child theme.

themes/goodbids-main/assets/fonts/cardo/cardo_italic_400.woff2

themes/goodbids-nonprofit/style.css

themes/goodbids-main/readme.txt

themes/goodbids-main/templates/404.html

bd-viget

Looking great! One update to the Namespace and Since tags, and should be good to go!

themes/goodbids-main/functions.php

themes/goodbids-main/patterns/banner-project-description.php

bd-viget

Chatted you directly about the @since, otherwise good to go!

nathan-schmidt-viget commented Dec 20, 2023

View reviewed changes

themes/goodbids-main/screenshot.png Outdated

Copy link

Contributor Author

nathan-schmidt-viget Dec 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom screenshot for the main theme

nathan-schmidt-viget commented Dec 20, 2023

View reviewed changes

themes/goodbids-main/style.css

Copy link

Contributor Author

nathan-schmidt-viget Dec 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update style.css

nathan-schmidt-viget commented Dec 20, 2023

View reviewed changes

themes/goodbids-nonprofit/style.css

Copy link

Contributor Author

nathan-schmidt-viget Dec 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the nonprofit site to be a child of the goodbids main theme.

nathan-schmidt-viget commented Dec 20, 2023

View reviewed changes

nathan-schmidt-viget requested review from bd-viget and nathanlong December 20, 2023 21:18

nathan-schmidt-viget marked this pull request as ready for review December 20, 2023 21:19

nathan-schmidt-viget force-pushed the ns/78-goodbids-theme branch from 5e75cfe to e4580f9 Compare December 20, 2023 22:15

bd-viget suggested changes Dec 20, 2023

View reviewed changes

nathan-schmidt-viget requested a review from bd-viget December 21, 2023 15:49

nathan-schmidt-viget added 3 commits December 21, 2023 08:57

[#78] setting up goodbids main - removing remote patterns

8be01ee

[#78] updating other colors

c337b60

[#78] updating all twentytwentyfour references to goodbids-main

2945536

nathan-schmidt-viget force-pushed the ns/78-goodbids-theme branch from 0888976 to c9c8ae6 Compare December 21, 2023 15:59

bd-viget suggested changes Dec 21, 2023

View reviewed changes

themes/goodbids-main/functions.php Outdated Show resolved Hide resolved

themes/goodbids-main/functions.php Outdated Show resolved Hide resolved

themes/goodbids-main/functions.php Show resolved Hide resolved

themes/goodbids-main/patterns/banner-project-description.php Show resolved Hide resolved

[#78] updating PR based on notes

4220484

nathan-schmidt-viget force-pushed the ns/78-goodbids-theme branch from c9c8ae6 to 4220484 Compare December 21, 2023 16:29

nathan-schmidt-viget requested a review from bd-viget December 21, 2023 16:31

bd-viget approved these changes Dec 21, 2023

View reviewed changes

[#78] updating the since to 1.0.0

7fc698f

nathan-schmidt-viget merged commit 2bcd18f into main Dec 21, 2023
1 check passed

nathan-schmidt-viget deleted the ns/78-goodbids-theme branch December 21, 2023 16:46

nathan-schmidt-viget mentioned this pull request Dec 21, 2023

[#39] Fixing the logic on the auction featured image #114

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#78] setting up Goodbids main theme #110

[#78] setting up Goodbids main theme #110

nathan-schmidt-viget commented Dec 20, 2023

nathan-schmidt-viget Dec 20, 2023

nathan-schmidt-viget Dec 20, 2023

nathan-schmidt-viget Dec 20, 2023

nathan-schmidt-viget Dec 20, 2023

bd-viget Dec 20, 2023

nathan-schmidt-viget Dec 21, 2023

nathan-schmidt-viget Dec 20, 2023

nathan-schmidt-viget Dec 20, 2023

nathan-schmidt-viget Dec 20, 2023

nathan-schmidt-viget commented Dec 20, 2023

bd-viget left a comment

bd-viget Dec 20, 2023

bd-viget left a comment

bd-viget left a comment

[#78] setting up Goodbids main theme #110

[#78] setting up Goodbids main theme #110

Conversation

nathan-schmidt-viget commented Dec 20, 2023

Summary

Issues

Testing Instructions

Screenshots

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nathan-schmidt-viget commented Dec 20, 2023

bd-viget left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bd-viget left a comment

Choose a reason for hiding this comment

bd-viget left a comment

Choose a reason for hiding this comment