Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#39] Fixing the logic on the auction featured image #114

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

nathan-schmidt-viget
Copy link
Contributor

Summary

@shascher noticed we were not pulling in the auction featured image before the reward feature image. This adds that logic in before we default to the reward image and WooCommerce default image.

Issues

Testing Instructions

  • Go to an auction page and add a featured image.
  • Go to another auction page and make sure it does not have a featured image, but the reward product that it is linked to does have a featured image.
  • Go to a third auction page and make sure it does not have a featured image and the reward product does not have featured image.
  • Then go to the auction index /auctions and make sure it is pulling in like:

Auction Image - Use the featured image for the Auction if it's set. Otherwise, use the Main Product Image for the Prize Product associated with the Auction. If no Main Product Image is set on the Prize Product, WooCommerce will serve up a fallback.

Screenshots

Screenshot 2023-12-21 at 10 18 31 AM

@clatwell
Copy link
Contributor

@nathan-schmidt-viget @shascher is the Auction Featured Image pulling in with different dimensions from the Reward Product image, and if so, can we standardize (ie. crop height of auction featured image to match product image)?

@nathan-schmidt-viget
Copy link
Contributor Author

@clatwell Yes, they should be!
Apparently when I moved the auction index template in my PR into main and that caused WP to get all confused when I changed branches. I did a hard reload and here is what I am seeing now, back to all square images. 🎉

Screenshot 2023-12-21 at 11 36 19 AM

@clatwell
Copy link
Contributor

@nathan-schmidt-viget Hooray! Thanks for double-checking!

Copy link
Contributor

@bd-viget bd-viget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants