Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏓 Ping handling for FTL media streams #114

Merged
merged 1 commit into from
Mar 20, 2021
Merged

🏓 Ping handling for FTL media streams #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/FtlStream.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,11 +587,8 @@ void FtlStream::processAudioVideoRtpPacket(const std::vector<std::byte>& rtpPack

void FtlStream::handlePing(const std::vector<std::byte>& rtpPacket)
{
// These pings are useless - FTL tries to determine 'ping' by having a timestamp
// sent across and compared against the remote's clock. This assumes that there is
// no time difference between the client and server, which is practically never true.

// We'll just ignore these pings, since they wouldn't give us any useful information anyway.
// FTL client is trying to measure round trip time (RTT), pong back the same packet
mediaTransport->Write(rtpPacket);
}

void FtlStream::handleSenderReport(const std::vector<std::byte>& rtpPacket)
Expand Down