🏓 Ping handling for FTL media streams #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested locally and verified my bandwidth was measured correctly (well the client maxes at 15mbps on the speed test so it just said that, but that's more accurate than how it used to say 5005kbps exactly always) |
haydenmc
approved these changes
Mar 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ping is not expected to be used by the server, it is meant to be ponged back to the client as part of measuring RTT.
Now it's true the client only uses this right now to do a bandwidth test it then ignores, but it does log the bandwidth so it'd be nice for debugging to have the numbers be accurate (right now the client defaults to a two second RTT because it never gets a pong to measure)
See https://github.com/Glimesh/ftl-sdk/blob/5912733506c066684aebd43f3e0b94cf51ca98c1/libftl/media.c#L1165-L1174