Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): update notifications device token validation length #4657

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix(core): update notifications device token validation length #4657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions core/api/src/domain/users/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,15 @@ export const checkedToNonEmptyLanguage = (
}

export const checkedToDeviceToken = (token: string): DeviceToken | ValidationError => {
// token from firebase have a length of 163
const correctLength = 163
if (token.length !== correctLength) {
// iOS tokens: 64 chars (min)
// Android tokens: up to 200 chars (max)
// Firebase: 142 chars but it is variable
const minLength = 64
const maxLength = 200

if (token.length < minLength || token.length > maxLength) {
return new InvalidDeviceTokenError(
`wrong length, expected ${correctLength}, got ${token.length}`,
`Invalid token length. Expected between ${minLength}-${maxLength}, got ${token.length}`,
)
}

Expand Down
Loading