Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): update notifications device token validation length #4657

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

dolcalmi
Copy link
Collaborator

Fix https://ui.honeycomb.io/galoy/datasets/galoy-bbw/result/C15uWKBN8Gk?hideCompare

I could not find any update in firebase documentation but we can use this info as base:

iOS (APNS): 64 characters
Android: 140-200 characters (variable length)
Firebase: 142 according to error message

@dolcalmi dolcalmi requested a review from openoms November 14, 2024 20:01
@github-actions github-actions bot added the core label Nov 14, 2024
@openoms openoms merged commit 60f5af1 into main Nov 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants