test: move ln tests to top level bats #3593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| load "../../helpers/subscriber.bash" | ||
|
|
||
| setup_file() { | ||
| lnds_init |
There was a problem hiding this comment.
Initialising the lightning setup should be done as part of tilt up IMO
| fund_user_lightning 'alice' 'btc_wallet' '500000' | ||
|
|
||
| subscribe_to 'alice' my-updates-sub | ||
| sleep 3 |
There was a problem hiding this comment.
Why sleep 3? Can we have a loop to detect when we're done. Sleep tends to be flaky.
| btc_wallet_name="alice.btc_wallet_id" | ||
|
|
||
| # Stop trigger | ||
| # stop_trigger |
|
|
||
| # Start trigger | ||
| # start_trigger | ||
| sleep 5 |
| lnd_outside_cli payinvoice -f \ | ||
| --pay_req "$payment_request" \ | ||
| --amt "$btc_amount" \ | ||
| & |
| retry 15 1 check_for_ln_initiated_settled "$token_name" "$payment_hash" | ||
| } | ||
|
|
||
| lnds_init() { |
There was a problem hiding this comment.
This should probably be a setup step in the tilt file.
This is probably the most important assertion of the test - can't merge with out it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves LN tests to top level bats
TODO: Make sure balance_for_check is readded