Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move ln tests to top level bats #3719

Merged
merged 20 commits into from
Dec 21, 2023
Merged

test: move ln tests to top level bats #3719

merged 20 commits into from
Dec 21, 2023

Conversation

vindard
Copy link
Contributor

@vindard vindard commented Dec 16, 2023

Takes over from #3593

@gitguardian GitGuardian
Copy link

gitguardian bot commented Dec 16, 2023 •
edited
Loading

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
7652397 Generic High Entropy Secret e836af3 dev/Tiltfile View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@vindard vindard force-pushed the move-lnds-bats branch 7 times, most recently from 50bb7f7 to c2e051f Compare December 18, 2023 20:32
@vindard vindard marked this pull request as ready for review December 18, 2023 20:33
@vindard vindard force-pushed the move-lnds-bats branch 11 times, most recently from 117633f to 158ef9c Compare December 19, 2023 05:01
@vindard vindard marked this pull request as draft December 19, 2023 19:21
@github-actions github-actions bot removed the core label Dec 19, 2023
@github-actions github-actions bot added the core label Dec 19, 2023
@vindard vindard force-pushed the move-lnds-bats branch 2 times, most recently from 2d4049c to f471d3a Compare December 20, 2023 02:09
@vindard vindard requested a review from dolcalmi December 20, 2023 02:28
@vindard vindard requested a review from bodymindarts December 20, 2023 02:28
@vindard vindard marked this pull request as ready for review December 20, 2023 15:07
vindard added 20 commits December 20, 2023 11:24
@vindard
build: add callback server to Tiltfile
e836af3
@vindard
refactor: change svix extra-hosts name to 'bats-tests'
921bfad
@vindard
test(core): setup ln-receive suite and move 1st case
9a82eb4
@vindard
fix(core): add waits for lnd rpc endpoints to be ready
31764bc
@vindard
fix(core): add svix to api tilt deps
c4d09ac
@vindard
fix(core): retry lnd_outside connect
7d99079
@vindard
fix(core): source environment before running bats tests
168cd48
@vindard
test(core): move other basic ln-receive bats tests
0824c1c
@vindard
fix(core): add missing redis_cli for balance_for_check
2c9ebc2
@vindard
build(core): swap in stoppable trigger runner script
0079f5c
@vindard
test(core): move stop-trigger ln-receive bats tests
4985baf
@vindard
build(core): add init-lightning as api dependency
68bb1d9
@vindard
test(core): move first ln-send bats test
5ac63dd
@vindard
test(core): move rest of external-settled ln-send bats tests
b7ab6d0
@vindard
test(core): move first ln-send bats intraledger-settled test
8fe8d14
@vindard
test(core): move rest of intraledger-settled ln-send bats tests
bc65ac3
@vindard
test(core): move failure ln-send bats test
9fa4aac
@vindard
test(core): adjust ln-send balance check for prior tests
2e589ac
@vindard
test(core): remove subscriber sleep
49bea30
@vindard
test(core): remove trigger sleep
10d9bb6
bodymindarts
bodymindarts approved these changes Dec 21, 2023
View reviewed changes
.github/workflows/bats.yml
@@ -21,7 +21,7 @@ jobs:
//core/api-keys //apps/dashboard //apps/consent //apps/pay
- name: Run bats tests
run: |
nix develop -c bats --setup-suite-file bats/ci_setup_suite.bash -t bats/core/**
. ./.env && nix develop -c bats --setup-suite-file bats/ci_setup_suite.bash -t bats/core/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to find another way to inject env.

@vindard vindard merged commit 4e40596 into main Dec 21, 2023
14 of 15 checks passed
vindard added a commit that referenced this pull request Dec 22, 2023
@vindard
revert: move ln tests to top level bats (#3719)
00a03c7 
This reverts commit 4e40596.

This is to debug the .e2e-tilt.log file in CI and then bring this back
in.
vindard added a commit that referenced this pull request Dec 22, 2023
@vindard
revert: move ln tests to top level bats (#3719) (#3744)
2d849fd 
This reverts commit 4e40596.

This is to debug the .e2e-tilt.log file in CI and then bring this back
in.
vindard added a commit that referenced this pull request Dec 22, 2023
@vindard
test: move ln tests to top level bats (#3719) (#3744)"
f3ae42e 
This reverts commit 2d849fd.
vindard added a commit that referenced this pull request Dec 22, 2023
@vindard
test: move ln tests to top level bats (#3719) (#3744)
f1aea45 
This reverts commit 2d849fd.
vindard added a commit that referenced this pull request Dec 23, 2023
@vindard
test: move ln tests to top level bats (#3719) (#3744) (#3750)
2a6c744 
* test: move ln tests to top level bats (#3719) (#3744)

This reverts commit 2d849fd.

* chore: remove SVIX_CALLBACK_URL from environment

* refactor: change trigger_is_started to be exact
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodymindarts bodymindarts bodymindarts approved these changes

@dolcalmi dolcalmi Awaiting requested review from dolcalmi

Assignees
No one assigned
Labels
ci core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vindard @bodymindarts