Added methods to quickly generate common series #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finomnis
reviewed
Mar 16, 2024
Finomnis
reviewed
Mar 16, 2024
|
I like it. Thanks for your contribution :) |
|
If you make the linters happy, I'll merge :) |
|
Ah, that's what's failing! I'm not that familiar with this pipeline. :D |
If you click on "details" next to the failed ones, you will see explanations. If you don't manage to fix it, tell me, then I'll fix it for you. |
|
The linters you need to satisfy are |
Finomnis
reviewed
Mar 18, 2024
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added constants for the common resistor values series, E12 and E24.
Added methods
generate_decadeandgenerate_decadeswhich scale those series by powers of 10 and create 2D arrays of values.Updated the comments and examples.