Merge pull request #535 from Financial-Times/longer-wait-for-review

Wait longer for review apps to complete
Financial-Times · Nov 26, 2018 · 10a4791 · 10a4791
2 parents c0b3dea + 77b035a
commit 10a4791
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/review-apps.js b/lib/review-apps.js
@@ -9,7 +9,7 @@ const DEFAULT_HEADERS = {
 	'Content-Type': 'application/json'
 };
 
-const NUM_RETRIES = 30;
+const NUM_RETRIES = 60;
 const RETRY_EXP_BACK_OFF_FACTOR = 1;
 const MIN_TIMEOUT = 10 * 1000;
 const REVIEW_APP_STATUSES = {

diff --git a/lib/review-apps.unit.test.js b/lib/review-apps.unit.test.js
@@ -302,7 +302,7 @@ describe('review-apps', () => {
 			const appId = 'app123';
 			nockScope
 				.get('/apps/app123/builds')
-				.times(30)
+				.times(60)
 				.reply(200, []);
 
 			return waitForReviewAppBuild({
@@ -415,7 +415,7 @@ describe('review-apps', () => {
 			};
 			reviewAppsNockScope
 				.get('/review-apps/reviewApp123')
-				.times(30)
+				.times(60)
 				.reply(200, []);
 
 			return waitTillReviewAppCreated({ minTimeout: 0 })(reviewApp)