Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

Commit

Permalink
Merge pull request #533 from Financial-Times/chores/add-output-quotes
Browse files Browse the repository at this point in the history
Add quotes for output messages 🐿 v2.10.3
  • Loading branch information
taktran authored Nov 21, 2018
2 parents b551843 + 1c29ea9 commit c0b3dea
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions lib/review-apps.js
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,12 @@ const waitForReviewAppBuild = ({ commit, minTimeout = MIN_TIMEOUT }) => async (a
const build = builds.find(({ source_blob: { version } }) => version === commit);

if (!build) {
throw new Error(`No review app build found for app id ${appId}, commit ${commit}`);
throw new Error(`No review app build found for app id '${appId}';, commit '${commit}'`);
}

const { status } = build;
if (status !== BUILD_STATUS_SUCCEEDED) {
throw new Error(`Review app build for app id ${appId} (commit ${commit}) not done yet: ${status}`);
throw new Error(`Review app build for app id '${appId}' (commit '${commit}') not done yet: ${status}`);
}

return build;
Expand Down
2 changes: 1 addition & 1 deletion tasks/review-app.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ async function task (appName, options) {
.then(res => {
const { status } = res;
if (status === 409) {
console.error(`Review app already created for ${branch} branch. Using existing review app for build.`); // eslint-disable-line no-console
console.error(`Review app already created for '${branch}' branch. Using existing review app for build.`); // eslint-disable-line no-console
return findCreatedReviewApp({
pipelineId,
branch
Expand Down

0 comments on commit c0b3dea

Please sign in to comment.