Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Readable Stream read 16,384 objects #42

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Fix: Readable Stream read 16,384 objects #42

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e32dea
fix readAsPromised - stuck if stream alredy "end" #36
Jan 24, 2024
5954313
Merge branch 'Faleij:master' into master
SlavikPr Mar 18, 2024
7bd1310
Fix: Readable Stream read 16,384 objects in ObjectMode #41
Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/JsonStreamStringify.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ function quoteString(string: string) {
return str;
}

function readAsPromised(stream, size) {
function readAsPromised(stream, size?) {
const value = stream.read(size);
if (value === null) {
return new Promise((resolve, reject) => {
Expand Down Expand Up @@ -327,10 +327,10 @@ export class JsonStreamStringify extends Readable {
let i = 0;
const item = <any>{
type: 'readable object',
async read(size: number) {
async read() {
try {
let out = '';
const data = await readAsPromised(input, size);
const data = await readAsPromised(input);
if (data === null) {
if (i && that.indent) {
out += `\n${parent.indent}`;
Expand Down
Loading