Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Readable Stream read 16,384 objects #42

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Conversation

SlavikPr
Copy link
Contributor

Fix readebleStream in objectMode read 16,384 object and ignore highWaterMark.

my suggestion:

   // function - setReadableObjectItem(input: Readable, parent: Item)
   const item = <any>{
      type: 'readable object',
      async read() {
        try {
          let out = '';
          // if send size as undefined ReadebleStream will use highWaterMark
          const data = await readAsPromised(input);
          if (data === null) {
            if (i && that.indent) {
              out += `\n${parent.indent}`;
            }

@coveralls
Copy link

Coverage Status

coverage: 0.0%. remained the same
when pulling 7bd1310 on SlavikPr:master
into ec71d61 on Faleij:master.

@Faleij Faleij merged commit 1555b22 into Faleij:master Mar 30, 2024
9 checks passed
@Faleij
Copy link
Owner

Faleij commented Mar 30, 2024

Thanks for submitting an issue and a pull request. New version will be up shortly on NPM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants