Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ents.FindByClassAndParent #2167

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Optimize ents.FindByClassAndParent #2167

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e29d6ce
Optimize ents.FindByClassAndParent
Astralcircle Dec 2, 2024
f1e8ca2
Remove whitespace
Astralcircle Dec 3, 2024
a0e1f30
Woops
Astralcircle Dec 3, 2024
f3f4fbc
Use ipairs
Astralcircle Dec 3, 2024
983cb10
Don't create new variable, small formatting
Astralcircle Jan 3, 2025
18a238e
Check parent validity only once
Astralcircle Jan 3, 2025
69a53c8
Check the validity of the parent only once
Astralcircle Jan 3, 2025
bb4c5c6
C formatting
Astralcircle Jan 3, 2025
b6d2021
Even more formatting
Astralcircle Jan 3, 2025
847b36c
Final formatting fix
Astralcircle Jan 17, 2025
051f2a9
Woops
Astralcircle Jan 17, 2025
29f1a00
I hope this is the last time
Astralcircle Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 9 additions & 15 deletions garrysmod/lua/includes/extensions/ents.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,21 @@

function ents.FindByClassAndParent( classname, entity )

if ( !IsValid( entity ) ) then return end
if ( !IsValid( entity ) ) then return end

local list = ents.FindByClass( classname )
if ( !list ) then return end
local out = {}

local out = {}
for k, v in ipairs( list ) do
for k, v in ipairs( ents.FindByClass( classname ) ) do

if ( !IsValid(v) ) then continue end
if ( v:GetParent() == entity ) then
table.insert( out, v )
end

local p = v:GetParent()
if ( !IsValid(p) ) then continue end
if ( p != entity ) then continue end
end

table.insert( out, v )
if ( out[1] == nil ) then return end

end

if ( #out == 0 ) then return end

return out
return out

end

Expand Down