Optimize ents.FindByClassAndParent

[Astralcircle]

Optimizes this function by about 25%

Benchmark code:

local SysTime = SysTime
local ipairs = ipairs
local MsgN = MsgN

function GMODBenchmark(repeats, ...)
    local times = {}

    for k, benchmark_function in ipairs({...}) do
        local start_time = SysTime()

        for i = 1, repeats do
            benchmark_function()
        end

        local end_time = SysTime()
        times[k] = end_time - start_time
    end

    MsgN(string.format("\nBenchmark result %s:", SERVER and "(SERVER)" or "(CLIENT)"))
    for k, v in ipairs(times) do
        MsgN(k, ": " .. v)
    end
end

Benchmark:

function ents.FindByClassAndParent2( classname, entity )

    local entslist = ents.FindByClass( classname )
	local out = {}

    for k, v in ipairs( entslist ) do

        local p = v:GetParent()
		if ( !IsValid(p) ) then continue end
		if ( p != entity ) then continue end

		table.insert( out, v )

    end

	if ( out[1] == nil ) then return end

	return out

end

local e = Entity(1)

--155 props parented to player
GMODBenchmark(10000, 
function()
    local a = ents.FindByClassAndParent2("prop_physics", e)
end,
function()
    local a = ents.FindByClassAndParent("prop_physics", e)
end)

Result:

Benchmark result (SERVER):
1: 0.26664929999993
2: 0.35286960000008

[aStonedPenguin]

Just use ipairs. With jit it should be the same speed, and cleaner.