Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for issue #7, #8, #10 and #11 #9

Closed
wants to merge 5 commits into from
Closed

Fixes for issue #7, #8, #10 and #11 #9

wants to merge 5 commits into from

Conversation

unicod3
Copy link

@unicod3 unicod3 commented Nov 9, 2017

Hi,
First of all thanks for this great repo.
I tried to initialize the formset in a modal but I had this problem that when I first open model and click the add button everything works fine but then if I don't refresh the page and open another modal with formset and click the add button it added more than one form(in the numbers of models that i open and close).
That was a strange issue and I found that if I add off method before the on method issue fixed. #11

@unicod3
Copy link
Author

unicod3 commented Nov 9, 2017

Later on, I also had to add the fix @truhlik suggested on #7 for my project

@unicod3
Copy link
Author

unicod3 commented Nov 9, 2017

Well, this will also fix #10 with the commit 3 but I think #10 can be solved with a better approach.

@unicod3 unicod3 changed the title Add off method into add-form Fixes for issue #7 #10 and #11 Nov 9, 2017
@unicod3
Copy link
Author

unicod3 commented Nov 12, 2017

Well, I also write a method for issue #8
Now it hides the last item's delete button, and if you click the add button it shows the delete button again.

@unicod3 unicod3 changed the title Fixes for issue #7 #10 and #11 Fixes for issue #7, #8, #10 and #11 Nov 12, 2017
@truhlik
Copy link

truhlik commented Apr 4, 2018

Hi @unicod3 thank you for these commits.

I have tested and found one bug. I found that DELETE button is completely missing in all forms in formset. But after clicking on ADD button then DELETE button appears everywhere.
I check your code, but don't see any problem. Could you fix? Thank you.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants