Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update node versions in tests #1144

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

patrickarlt
Copy link
Contributor

@patrickarlt patrickarlt commented Dec 28, 2023

Updates to Node 18 and 20 in the automated test suite.

#1138

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b5da30d) 100.00% compared to head (1d8ac5f) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1144   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          177       177           
  Lines         3247      3247           
  Branches       551       551           
=========================================
  Hits          3247      3247           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patrickarlt
Copy link
Contributor Author

Adding this as a note about what might be happening parcel-bundler/parcel#8152. Something is using lmdb and is failing and probably needs to be updated in a demo.

@gavinr-maps
Copy link
Contributor

🎉

@gavinr-maps gavinr-maps merged commit e317d17 into main Feb 21, 2024
4 checks passed
@gavinr-maps gavinr-maps deleted the update-automated-tests branch February 21, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants