Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update automated unit tests to run on Node 20 #1138

Closed
gavinr-maps opened this issue Oct 25, 2023 · 4 comments
Closed

Update automated unit tests to run on Node 20 #1138

gavinr-maps opened this issue Oct 25, 2023 · 4 comments
Labels
good first issue Good for newcomers and beginners help wanted small fix

Comments

@gavinr-maps
Copy link
Contributor

gavinr-maps commented Oct 25, 2023 •
edited
Loading

Describe the problem

Node v20 is now the current active LTS version:
https://github.com/nodejs/release#release-schedule

image

Describe the proposed solution

So we should probably add v20 to the list of versions that we automatically test on:

arcgis-rest-js/.github/workflows/pull-request-tests.yml

Line 21 in 9ec89a2

node: [14, 16, 18]

Alternatives considered

No response

Additional Information

Questions:

  • Should we also remove Node 14 from the automated unit tests (end of life was 2023-04-30)?
  • Should we also remove Node 16 from the automated unit tests (end of life was 2023-09-11)?
@gavinr-maps gavinr-maps changed the title Update unit tests to test Node 20 Update automated unit tests to run on Node 20 Oct 25, 2023
@patrickarlt
Copy link
Contributor

I think we should remove 14 and 16.

@gavinr-maps gavinr-maps added help wanted good first issue Good for newcomers and beginners small fix labels Oct 25, 2023
@0scvr
Copy link

0scvr commented Oct 25, 2023

I would like to work on this issue, please :)

@patrickarlt
Copy link
Contributor

@0scvr all yours!

@0scvr 0scvr mentioned this issue Dec 9, 2023
Closed
@gavinr-maps gavinr-maps mentioned this issue Feb 20, 2024
Merged
@gavinr-maps
Copy link
Contributor Author

Updated in #1144 - thanks @0scvr and @patrickarlt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers and beginners help wanted small fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@patrickarlt @0scvr @gavinr-maps