ci: Spellcheck GH action #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serdardalgic
changed the base branch from
main
to
conventional-commit-checker-GH-action
serdardalgic
force-pushed
the
spellcheck-GH-action
branch
from
4119f0a to
ab36d90
Compare
drsm79
previously approved these changes
Nov 14, 2022
serdardalgic
force-pushed
the
conventional-commit-checker-GH-action
branch
from
38e5308 to
5745edd
Compare
serdardalgic
force-pushed
the
spellcheck-GH-action
branch
from
ab36d90 to
297cbc9
Compare
Base automatically changed from
conventional-commit-checker-GH-action
to
main
November 15, 2022 13:45
nstott
reviewed
Nov 15, 2022
| IOPS | ||
| InstanceType | ||
| Postgres | ||
| biganimal |
There was a problem hiding this comment.
should Biganimal be capitalized?
There was a problem hiding this comment.
Unfortunately, spellchecker is not clever enough to distinguish when a word appears. This biganimal is coming from
terraform {
required_providers {
biganimal = {
source = "biganimal"
version = "0.3.1"
}
}
}
And, with the current implementation, if we use biganimal in, let's say, README.md, it will accept it. 🤷 not the best implementation, but I don't have any suggestions for fixing it. If you have, I'd love to hear.
And I've only added the words that the spellchecker was complaining about. Biganimal wasn't one of them.
For more info on configuration, please visit https://facelessuser.github.io/pyspelling/configuration/ The spellcheck is only applied on the markdown files in the documentation.
serdardalgic
force-pushed
the
spellcheck-GH-action
branch
from
71e2ff6 to
9d2b728
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two checkers:
The
.wordlist-en-custom.txtfile is generated after the output of the spellchecker.Please review.
Related to #42. Please merge it after merging #49