Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Linter to check the terraform code and update the docs #42

Closed
serdardalgic opened this issue Nov 9, 2022 · 3 comments
Closed

Use Linter to check the terraform code and update the docs #42

serdardalgic opened this issue Nov 9, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code

Comments

@serdardalgic
Copy link
Contributor

We need to set up a mechanism to terraform fmt the code, and also go generate the docs and the examples.
We can set up a pre-commit hook so that the developers/contributers can check their code.

Even better, we can automate this system, such as https://terraform-docs.io/how-to/github-action/

@serdardalgic
Copy link
Contributor Author

Copying this comment @nstott here:

before we publish the provider, I think we should

  • automate the doc generation
  • linters
  • check the doc text associated with the different properties to catch typos, bad copy pasta, etc
  • add examples

@serdardalgic serdardalgic added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Nov 9, 2022
@serdardalgic
Copy link
Contributor Author

I think we can group the linters in such categories:

For the naming and best-practice check, We can check https://github.com/terraform-linters/tflint.

@serdardalgic
Copy link
Contributor Author

serdardalgic commented Nov 15, 2022

I'd like to tear down this issue into smaller pieces:

I created a new issue for

The following checkers are addressed with PRs

After #50 is merged, I think we can close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

No branches or pull requests

1 participant