Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overload footer with dragOptions #910

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Overload footer with dragOptions #910

merged 4 commits into from
Oct 31, 2023

Conversation

snehmehta
Copy link
Collaborator

Ticket: #817

@snehmehta snehmehta requested a review from vusters October 26, 2023 14:45
@snehmehta snehmehta linked an issue Oct 26, 2023 that may be closed by this pull request
@vusters
Copy link
Contributor

vusters commented Oct 26, 2023

@snehmehta Please overwrite the existing footer widget instead of creating a new widget. That widget has some issues where the scope is not the same as the main page. @vinothvino42 has the detail.

@snehmehta snehmehta changed the title new widget: DraggableSheet Overload footer with dragOptions Oct 27, 2023
@vinothvino42
Copy link
Collaborator

vinothvino42 commented Oct 30, 2023

@snehmehta See this comment - #844 (comment)
Can you re-assign yourself for this issue if you're working on this ticket?

@vusters
Copy link
Contributor

vusters commented Oct 30, 2023

@snehmehta add the schema and you are good to go

@snehmehta
Copy link
Collaborator Author

@snehmehta See this comment - #844 (comment) Can you re-assign yourself for this issue if you're working on this ticket?

hey @vinothvino42 I haven't check that issue yet and I have few high priority ticket left as well. Let me know if it's blocking something I'll have a look at it.

@snehmehta snehmehta merged commit 0d82b45 into main Oct 31, 2023
2 checks passed
@snehmehta snehmehta deleted the feat/draggable-sheet branch October 31, 2023 10:57
@kmahmood74 kmahmood74 mentioned this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bottomModal with fixed content
3 participants