Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix pagination parameters for child user lists #578

Merged
merged 2 commits into from
Aug 2, 2024
Merged

[bug] Fix pagination parameters for child user lists #578

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e06aadc
- Fix pagination parameters for child user lists
nwithan8 Aug 1, 2024
a184a73
Update CHANGELOG.md
nwithan8 Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## Next Release

- Fix pagination parameters for `GetNextPageOfChildren` function
nwithan8 marked this conversation as resolved.
Show resolved Hide resolved

## v6.7.0 (2024-07-24)

- Add new `Claim` service for filing claims on EasyPost shipments and insurances
Expand Down
14 changes: 7 additions & 7 deletions EasyPost.Tests/cassettes/net/user_service/get_next_page_of_children.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions EasyPost.Tests/cassettes/netstandard/user_service/get_next_page_of_children.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion EasyPost/Models/API/ChildUserCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public override TParameters BuildNextPageParameters<TParameters>(IEnumerable<Use
{
AllChildren parameters = Filters != null ? (AllChildren)Filters : new AllChildren();

parameters.BeforeId = entries.Last().Id;
parameters.AfterId = entries.Last().Id;

if (pageSize != null)
{
Expand Down
Loading