Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Fix pagination parameters for child user lists #578

Merged
merged 2 commits into from
Aug 2, 2024
Merged

[bug] Fix pagination parameters for child user lists #578

merged 2 commits into from
Aug 2, 2024

Conversation

nwithan8
Copy link
Member

@nwithan8 nwithan8 commented Aug 1, 2024

Description

Pagination for listing child users needs to use "after_id", not "before_id"

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team August 1, 2024 21:22
jchen293
jchen293 approved these changes Aug 1, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@nwithan8 @jchen293
Update CHANGELOG.md
a184a73 
Co-authored-by: Jack Chen <[email protected]>
@nwithan8 nwithan8 merged commit 3b23afb into master Aug 2, 2024
14 checks passed
@nwithan8 nwithan8 deleted the list_children_params branch August 2, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchen293 jchen293 jchen293 approved these changes

@Justintime50 Justintime50 Justintime50 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwithan8 @jchen293 @Justintime50