Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace dynamic part with hex value when parsing schemas for Mapping keys #400

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

CJ42
Copy link
Collaborator

@CJ42 CJ42 commented Mar 27, 2024

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

Feature ⭐

What is the current behaviour (you can also link to an open issue here)?

Currently, the function getSchema returns ????? in the dynamic part for Mapping key type.

image

What is the new behaviour (if this is a feature change)?

Change this behaviour so that dynamic part of data keys are replaced by the hex value in the name, when dynamic part is something such as <address> or <bytes32>

Other information:

@richtera richtera merged commit b9d8f7b into develop Apr 2, 2024
2 checks passed
@richtera richtera deleted the feat/mapping-key=parser branch April 2, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants