-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dynamicName
in schema returned by getSchema
#428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CJ42
force-pushed
the
feat/dynamic-name-schema
branch
from
April 28, 2024 22:04
3413800
to
12d34d2
Compare
CJ42
changed the title
feat: add
feat: add Apr 29, 2024
dynamicPart
in schema returned by getSchema
dynamicName
in schema returned by getSchema
richtera
requested changes
Apr 29, 2024
richtera
approved these changes
Apr 30, 2024
richtera
approved these changes
Apr 30, 2024
richtera
approved these changes
Apr 30, 2024
CJ42
force-pushed
the
feat/dynamic-name-schema
branch
from
April 30, 2024 15:09
7ce9ab4
to
0175c4f
Compare
richtera
approved these changes
Apr 30, 2024
CJ42
force-pushed
the
feat/dynamic-name-schema
branch
from
May 2, 2024 08:49
5ad3ef0
to
902b2be
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #428 +/- ##
===========================================
- Coverage 83.71% 81.65% -2.07%
===========================================
Files 18 22 +4
Lines 1130 1401 +271
Branches 255 319 +64
===========================================
+ Hits 946 1144 +198
- Misses 98 150 +52
- Partials 86 107 +21 ☔ View full report in Codecov by Sentry. |
CJ42
force-pushed
the
feat/dynamic-name-schema
branch
2 times, most recently
from
May 2, 2024 23:17
693e2c9
to
cf05f53
Compare
…rt` for `Mapping`
CJ42
force-pushed
the
feat/dynamic-name-schema
branch
from
May 3, 2024 15:05
cf05f53
to
6b73a7e
Compare
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
⭐ Feature
What is the current behaviour (you can also link to an open issue here)?
#400 introduced a change in the
getSchema
function that replaces the dynamic part<...>
with the actual hex value in thename
of the schema.However, this causes a problem has the schem returned cannot be used anymore as it will the
name
now contains a hex value andERC725.encodeData
orERC725.decodeData
will not find the name anymore when searching through the data keys.What is the new behaviour (if this is a feature change)?
dynamicName
returned in the schema when dealing withMapping
andMappingWithGrouping
data keys when usinggetSchema(...)
name
of the data key to address the issue mentioned above.getSchema
function standalone, to make it available outside of class instanceOther information:
None