Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor!: remove supportsInterface" #359

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

Hugoo
Copy link
Contributor

@Hugoo Hugoo commented Nov 29, 2023

This reverts commit ab83f08.

Reverts: #352

The reason to remove the function was that:

  • the interface ID get outdated fast
  • and it is better to ask user to do the normal "erc165" way to check interface

See conv: #317

However, these interface IDs will be modified less and less in the future.

At this stage, it is too early to remove this function for the next release.

@Hugoo Hugoo mentioned this pull request Nov 29, 2023
@Hugoo Hugoo merged commit 3b48b0e into develop Nov 29, 2023
2 checks passed
@Hugoo Hugoo deleted the revert-removesupportinterface branch November 29, 2023 11:18
@Hugoo Hugoo mentioned this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants