Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync main #358

Merged
merged 10 commits into from
Nov 29, 2023
Merged

Sync main #358

merged 10 commits into from
Nov 29, 2023

Conversation

CallumGrindle
Copy link
Collaborator

@CallumGrindle CallumGrindle commented Nov 28, 2023

Sync main to release latest changes

dependabot bot and others added 8 commits November 10, 2023 08:47
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor: extract to internal methods

* refactor: improve method to extract tuple elements
* feat: add `encode/decodeValueType` as public callable methods

* docs: improve parameter names + add examples in documentation
* feat(wip): allow to encode LSP2 Array length only

* refactor: add typing `number` for `EncodeDataType`

* docs: add docs for encode array length

---------

Co-authored-by: Hugo Masclet <[email protected]>
…355)

* feat: add support for more value types

* refactor: extract to internal methods

* refactor: improve method to extract tuple elements

* feat: support encoding for unsigned integers from `uint8` to `uint256`

* refactor: replace complex regex with modulo
@codecov-commenter
Copy link

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (e7ed169) 83.42% compared to head (ba92903) 83.55%.
Report is 146 commits behind head on main.

Files Patch % Lines
src/lib/encoder.ts 89.23% 7 Missing and 7 partials ⚠️
src/lib/utils.ts 81.48% 5 Missing and 5 partials ⚠️
src/index.ts 71.42% 4 Missing and 2 partials ⚠️
src/lib/decodeData.ts 92.85% 0 Missing and 2 partials ⚠️
src/lib/decodeMappingKey.ts 60.00% 1 Missing and 1 partial ⚠️
src/lib/getDataFromExternalSources.ts 33.33% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
+ Coverage   83.42%   83.55%   +0.12%     
==========================================
  Files          18       18              
  Lines        1062     1204     +142     
  Branches      234      272      +38     
==========================================
+ Hits          886     1006     +120     
- Misses         96      105       +9     
- Partials       80       93      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CallumGrindle CallumGrindle requested a review from Hugoo November 29, 2023 08:40
@Hugoo
Copy link
Contributor

Hugoo commented Nov 29, 2023

Waiting for #359 to be merged then go

@Hugoo Hugoo merged commit 4cda9b9 into main Nov 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants