Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update distribution pipeline #314

Closed
wants to merge 40 commits into from
Closed

Update distribution pipeline #314

wants to merge 40 commits into from

Conversation

psomhorst
Copy link
Contributor

@psomhorst psomhorst commented Oct 18, 2024

This PR started out small, but I added some improvements to several parts of the distribution pipeline.

  • To ensure eitprocessing keeps working on newer versions of Python, I added the test and build action for Python 3.11-3.13.
  • The image containing the data (ghcr.io/eit-alive/eittestdata:latest) only has Python 3.10 with pip installed. Instead of editing that image, I edited the GitHub action to mount the data from the image, and run the test and build on python:3.x-bookworm instead. This makes it easier to adapt to new Python versions and replace the data image in the future, if necessary. See comment below for new description.
  • The coveralls action was not working. I removed it from the test action and created a new action. Coveralls does not report well when run on pull requests (and they don't really make sense), so I restricted it to running on pushes to main and develop.
  • I updated the linting action to install the ruff version from pyproject.toml. I already forgot to update the version in the action once, not planning on doing it again.
  • I updated the classifiers in the pyproject.toml file to better represent the (current status of) the project.
  • I added a py.typed file to the root of the package. This enables linters to use the source code for type checking when installing eitprocessing from package. (See https://peps.python.org/pep-0561/#packaging-type-information and https://mypy.readthedocs.io/en/stable/installed_packages.html#creating-pep-561-compatible-packages.)

@psomhorst psomhorst force-pushed the add_python_builds branch 5 times, most recently from 4da55a2 to cf38bb1 Compare October 18, 2024 09:42
@psomhorst psomhorst changed the title Add python builds Test multiple Python versions Oct 18, 2024
@psomhorst psomhorst changed the title Test multiple Python versions Test multiple Python versions, fix Coveralls Oct 18, 2024
@psomhorst psomhorst force-pushed the add_python_builds branch 3 times, most recently from daa95c1 to f34a9ba Compare October 18, 2024 11:01
@psomhorst psomhorst changed the base branch from main to develop October 18, 2024 11:02
@psomhorst psomhorst requested a review from DaniBodor October 18, 2024 11:05
@psomhorst psomhorst force-pushed the add_python_builds branch 2 times, most recently from c8e2d15 to fb31a6f Compare October 29, 2024 08:58
@psomhorst psomhorst changed the title Test multiple Python versions, fix Coveralls Update distribution pipeline Oct 29, 2024
@psomhorst psomhorst mentioned this pull request Nov 1, 2024
@DaniBodor DaniBodor requested a review from wbaccinelli November 7, 2024 10:20
@DaniBodor
Copy link
Member

This looks fine to me at first glance, but I am not very fluent at docker, so asked @wbaccinelli to review it instead. Also, things will change again soon in #303

Comment on lines 21 to 22
]
license = { text = "Apache-2.0 license" }
Copy link
Member

@DaniBodor DaniBodor Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also add the other authors above here, to make it match the CFF file

@DaniBodor DaniBodor linked an issue Nov 7, 2024 that may be closed by this pull request
@psomhorst
Copy link
Contributor Author

psomhorst commented Nov 7, 2024

This looks fine to me at first glance, but I am not very fluent at docker, so asked @wbaccinelli to review it instead. Also, things will change again soon in #303

I wasn't aware of #303. Maybe it's best to do that in this PR, instead of changing it twice. I think we can already remove the container requirement by extracting the data files from the container (https://github.com/marketplace/actions/docker-extract). This can then later be replaced, e.g. by downloading from Zenodo (although downloading from Zenodo seems to be quite slow).

I'll look into this tomorrow.

@psomhorst psomhorst force-pushed the add_python_builds branch 2 times, most recently from c1e8e00 to caf7529 Compare November 8, 2024 08:36
@psomhorst psomhorst force-pushed the add_python_builds branch 7 times, most recently from 6e4f095 to 48d0238 Compare November 8, 2024 14:52
@github-actions github-actions bot closed this Nov 8, 2024
@DaniBodor DaniBodor deleted the add_python_builds branch November 8, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update pyproject.toml
3 participants