-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update distribution pipeline #314
Conversation
4da55a2
to
cf38bb1
Compare
daa95c1
to
f34a9ba
Compare
c8e2d15
to
fb31a6f
Compare
This looks fine to me at first glance, but I am not very fluent at docker, so asked @wbaccinelli to review it instead. Also, things will change again soon in #303 |
] | ||
license = { text = "Apache-2.0 license" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe also add the other authors above here, to make it match the CFF file
f14aec4
to
3cee6ab
Compare
I wasn't aware of #303. Maybe it's best to do that in this PR, instead of changing it twice. I think we can already remove the container requirement by extracting the data files from the container (https://github.com/marketplace/actions/docker-extract). This can then later be replaced, e.g. by downloading from Zenodo (although downloading from Zenodo seems to be quite slow). I'll look into this tomorrow. |
c1e8e00
to
caf7529
Compare
a235caf
to
03436f7
Compare
6e4f095
to
48d0238
Compare
48d0238
to
11b34ed
Compare
56dec8a
to
3258ed9
Compare
1a659e9
to
d3a2f1b
Compare
0a09ca3
to
4978b74
Compare
This PR started out small, but I added some improvements to several parts of the distribution pipeline.
eitprocessing
keeps working on newer versions of Python, I added the test and build action for Python 3.11-3.13.Instead of editing that image, I edited the GitHub action to mount the data from the image, and run the test and build onSee comment below for new description.python:3.x-bookworm
instead. This makes it easier to adapt to new Python versions and replace the data image in the future, if necessary.main
anddevelop
.