Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the calucation of a single covearge and coverage depth value. #20

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Include the calucation of a single covearge and coverage depth value. #20

merged 4 commits into from
Sep 20, 2024

Conversation

mberacochea
Copy link
Member

@mberacochea mberacochea commented Sep 19, 2024 •
edited
Loading

These values are used when uploading the assembly to ENA.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • README.md is updated (including new tool citations and authors/contributors).

@mberacochea
Include the calucation of a single covearge and coverage depth value.
ab1d98c 
These values are used when uploading the assembly to ENA.
@mberacochea mberacochea self-assigned this Sep 19, 2024
Vkale1
Vkale1 approved these changes Sep 19, 2024
View reviewed changes
bin/calculate_assembly_covarege.py Outdated Show resolved Hide resolved
bin/calculate_assembly_covarege.py Outdated Show resolved Hide resolved
modules/local/calculate_assembly_coverage.nf Outdated Show resolved Hide resolved
KateSakharova
KateSakharova requested changes Sep 19, 2024
View reviewed changes
bin/calculate_assembly_covarege.py Outdated Show resolved Hide resolved
bin/calculate_assembly_covarege.py Outdated Show resolved Hide resolved
@mberacochea mberacochea merged commit 8969ad6 into main Sep 20, 2024
1 check passed
@mberacochea mberacochea deleted the feature/single-coverage-and-coverage-depth branch September 20, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vkale1 Vkale1 Vkale1 approved these changes

@SandyRogers SandyRogers Awaiting requested review from SandyRogers

@KateSakharova KateSakharova Awaiting requested review from KateSakharova

Assignees

@mberacochea mberacochea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mberacochea @Vkale1 @KateSakharova