Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when enabling minification #311

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

Komeyama
Copy link
Contributor

Issue

Overview (Required)

  • Changed org.jetbrains.androidx.navigation:navigation-compose to version 2.8.0-alpha08 to avoid crashes on screen transitions in release (and debug) builds as a workaround.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Unrelated to UI

Movie (Optional)

Before After
issue-257-before.mp4
issue-257-after.mp4

@Komeyama Komeyama marked this pull request as ready for review August 11, 2024 15:41
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 11, 2024 15:53 Inactive
Copy link

Snapshot diff report

File name Image
ContributorsScreenTe
st[ContributorsScree
n - when launch with
error - it should s
how error message]_c
ompare.png
TimetableItemDetailB
ottomAppBarBookmarke
dPreview_compare.png
TimetableItemDetailB
ottomAppBarPreview_c
ompare.png
TimetableItemDetailS
creenTest[TimetableI
temDetailScreen - wh
en server is operati
onal - when font sca
le is huge - it shou
ld show small font s
ession detail]_compa
re.png
TimetableItemDetailS
creenTest.runTest[Ti
metableItemDetailScr
een - when server is
operational - when
launch - it should b
e appropriately acce
ssible]_compare.png
TimetableItemDetailS
creenTest[TimetableI
temDetailScreen - wh
en server is operati
onal - when launch -
click bookmark - cl
ick bookmark again -
it should show unbo
okmarked session]_co
mpare.png
TimetableItemDetailS
creenTest[TimetableI
temDetailScreen - wh
en server is operati
onal - when launch -
scroll - it should
show scrolled sessio
n detail]_compare.pn
g
TimetableScreenTest[
TimetableScreen - wh
en server is down -
it should show error
message]_compare.pn
g
TimetableItemDetailS
creenTest[TimetableI
temDetailScreen - wh
en server is operati
onal - when launch -
it should show sess
ion detail title]_co
mpare.png
TimetableItemDetailS
creenTest[TimetableI
temDetailScreen - wh
en server is operati
onal - when launch -
click bookmark - it
should show bookmar
ked session]_compare
.png
TimetableItemDetailS
creenTest[TimetableI
temDetailScreen - wh
en server is operati
onal - when font sca
le is large - it sho
uld show small font
session detail]_comp
are.png
TimetableItemDetailS
creenTest[TimetableI
temDetailScreen - wh
en server is operati
onal - when font sca
le is small - it sho
uld show small font
session detail]_comp
are.png
TimetableItemDetailS
creenPreview_compare
.png
SponsorsScreenTest[S
ponsorsScreen - when
server is down - wh
en launch - it shoul
d show error message
]_compare.png
StaffScreenTest[Staf
fScreen - when serve
r is down - when lau
nch - it should show
snackbar]_compare.p
ng

@takahirom
Copy link
Member

Thank you for your investigation and contribution!

@takahirom takahirom merged commit 0f46257 into DroidKaigi:main Aug 11, 2024
5 checks passed
@Komeyama Komeyama deleted the feature-issue-257 branch August 12, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix crash when enabling minification
2 participants