Add app-desktop module #452

nyafunta9858 · 2024-08-14T15:17:23Z

Issue

close Add app-desktop module for faster development #300

Overview (Required)

Add a Compose for Desktop application's module, named app-desktop.
Add KmpDesktop plugin class.
Add Main class for app-desktop which only says Hello.
Add to import KmpCompose plugin into KmpDesktop plugin.

Links

Movie (Optional)

Launch from Run Configuration	Launch from source code	Launch from Gradle Tasks	Generate dmg package
2024-08-15.23.56.41.mov	2024-08-15.23.52.07.mov	2024-08-15.23.53.53.mov	2024-09-07.21.12.46.mov

Notes

Run (build and launch) the desktop application

./gradlew :app-desktop:run

Generate the desktop application dmg package.

./gradlew :app-desktop:packageDmg

It is probably better to use :app-desktop:packageDistributionForCurrentOS but this app is built only for debugging by contributors, so I set only for macOS dmg package format to configuration of targetFormats, now.
Therefore, it is enough to use packageDmg for checking build normally.

…sfiedLinkError that was caused to import Navigation Compose to app-desktop, made with compose multiplatform.

nyafunta9858 · 2024-08-14T15:29:26Z

build-logic/src/main/kotlin/io/github/droidkaigi/confsched/primitive/KmpDesktopPlugin.kt

+
+                    nativeDistributions {
+                        // TODO: set output formats of each platform
+                        targetFormats(TargetFormat.Dmg, /*TargetFormat.Msi, TargetFormat.Deb*/)


It needs to set up a configuration for each platform we need.
But... it probably no need to set it up if only executes from IDE or as a Gradle Task.

reference:
https://github.com/JetBrains/compose-multiplatform/blob/master/examples/imageviewer/desktopApp/build.gradle.kts

nyafunta9858 · 2024-08-14T15:29:59Z

build-logic/src/main/kotlin/io/github/droidkaigi/confsched/primitive/KmpDesktopPlugin.kt

+                            iconFile.set(iconsRoot.resolve("desktop-icon.png"))
+                        }
+                        // Setup Windows and Linux configuration if needed.
+//            windows {


It needs to set up a configuration for each platform we need.
But... it may be enough to be supported only for the macOS for a while.

reference:
https://github.com/JetBrains/compose-multiplatform/blob/master/examples/imageviewer/desktopApp/build.gradle.kts

nyafunta9858 · 2024-08-15T12:21:16Z

core/designsystem/build.gradle.kts

@@ -3,6 +3,7 @@ plugins {
    id("droidkaigi.primitive.kmp.android")
    id("droidkaigi.primitive.kmp.ios")
    id("droidkaigi.primitive.kmp.compose")
+    id("droidkaigi.primitive.kmp.desktop")


KmpDesktop plugin is applied here, but the main necessary definition is jvm() call.

It seems to be required to call from the desktop app.

nyafunta9858 · 2024-08-15T12:30:45Z

app-desktop/iconFiles/desktop-icon.png

Added the same as the Android logo icon.
It requires to preparation of icons for each platform as necessary.

reference:
https://github.com/JetBrains/compose-multiplatform/tree/master/examples/imageviewer/desktopApp/desktop-icons

github-actions · 2024-08-16T01:27:47Z

Detekt check failed. Please run ./gradlew detekt --auto-correct to fix the issues.

takahirom · 2024-08-16T01:35:06Z

Is there a Gradle task we can use to verify the desktop build for CI? I'm concerned it could break at any time.

…es for building packageDmg

nyafunta9858 · 2024-08-16T05:35:02Z

@takahirom
Thank you for your checking 🙏
We can use :app-desktop:packageDmg to check the build is normal on CI!
I use :app-desktop:run when launching the desktop app on Android Studio, but :app-desktop:packageDmg includes all steps of it, and creating dmg binary to install on macOs.

I have already added a workaround to gradle.properties, because it seemed to fail in checkRuntime, a step in :app-desktop:packageDmg, depending on the JDK distribution like the attached image.

takahirom · 2024-08-16T08:42:49Z

Maybe it is related to this issue and PR. We might have to use snapshot version of AndroidX 😇
#453

nyafunta9858 · 2024-08-16T09:09:01Z

@takahirom
This may be bad news. I updated the compose multiplatform plugin (org.jetbrains.compose) version from 1.6.11 to 1.7.0-alpha02 for importing compose navigation into app-desktop, but I noticed this update made several unit tests fail.
And I tried to test with the v1.6.11 compose multiplatform plugin and all test cases succeeded... ummmm
What shall I do this problem?

takahirom · 2024-08-17T07:02:49Z

As I was saying, we might have to update the snapshot version of AndroidX, but I'm not sure if it's safe.

Here are a couple of points to consider:

We may face test timeout issues if we use Foundation 1.7.
If we don't use Foundation 1.7, the problem you mentioned will occur.
https://github.com/DroidKaigi/conference-app-2024/pull/452/files#diff-697f70cdd88ba88fe77eebda60c7e143f6ad1286bca75017421e93ad84fb87dfR11-R13

nyafunta9858 · 2024-08-17T09:24:30Z

I see, I understand it. And I'm sorry for my misreading.
Thank you for your advice, I'll try to research solution that can avoid each issues.

nyafunta9858 · 2024-08-17T13:34:09Z

@takahirom
I will share my progress of investigation this PR's issues.
(It's still tough situation...)

In progress

Navigation Compose 2.8.0-alpha08 refers Compose Multiplatform 1.7.0-alpha01, and it requires 1.7.0-alpha01 or higher.
(Reference: https://youtrack.jetbrains.com/issue/CMP-5077/Compose-navigation-crash-v2.8.0-alpha08-UnsatisfiedLinkError)
If it requires to meet the above requirement, the desktop app can start normally. However, several tests fail due to influence that the above version of Compose Multiplatform refers Foundation 1.7.0-beta05 if it meets the above requirement. (Because not found IndicationNodeFactory)
(Reference: https://github.com/JetBrains/compose-multiplatform/releases/tag/v1.7.0-alpha01)
If I revert Navigation Compose to the previous version, 2.8.0-alpha02, it refers Compose Multiplatform 1.6.10-beta02, so I probably avoid the above issue.
However, Navigation Compose 2.8.0-alpha02 has a crash issue when enabling minification.
(Reference: Fix crash when enabling minification #311)
There seems to be a way to downgrade Navigation Compose to 2.7 or lower to avoid the above problem, but it causes to fail launching the desktop app...
(Reference: java.lang.NoSuchFieldError: No static field hide_in_inspector_tag of type I in class Landroidx/compose/ui/R$id; or its superclasses (declaration of 'androidx.compose.ui.R$id' appears in JetBrains/compose-multiplatform#4711 (comment))

nyafunta9858 · 2024-08-19T08:15:35Z

I've investigated a lot about the above issues, but I couldn't find a solution not to crash the desktop app, other than Compose Multiplatform Plugin bump up to 1.7.0-alpha01 or higher.
Therefore, in my opinion, I guess to be better the following steps to be taken. Please let me know your opinion. 🙏

To complete issue Add app-desktop module for faster development #300, remove references to navigation-compose from app-desktop module to avoid the crash issue. And then I will request your review again.
Create an issue ticket to resolve some problems this PR has been encountered.
In the above issue, we will be waiting for an update compose to fix Robolectric timeout issue.

…ktop' into feature/300-app-desktop

nyafunta9858 · 2024-08-24T17:18:57Z

@takahirom
I have finished removing dependencies to the Navigation Compose from the app-desktop module and added several todo comments that it needs to fix some issues to be available to use Navigation Compose on Compose Desktop.
And I checked both tasks were succeeded, unit tests and create desktop app package, :app-desktop:packageDistributionForCurrentOS and :app-desktop:packageDmg.

So once again, could you please review this PR whenever you are free?
Thanks for your kindness 🙏

takahirom · 2024-09-06T03:46:50Z

@nyafunta9858 I have a big news. foundation 1.8.0-alpha01 has been released and we should be able to upgrade the foundation 🎉

nyafunta9858 · 2024-09-07T01:08:59Z

Thanks for your beneficial information, @takahirom !
I too have encountered the following issue, so I'd like to retry building the desktop app and verifying unit tests after resolving it!
#984

takahirom · 2024-09-07T10:59:07Z

@nyafunta9858 I've merged the PR!

nyafunta9858 · 2024-09-07T12:30:10Z

@takahirom
I have committed some changes, and checked launching the desktop-app that depends on Navigation Compose normally.
So once again, could you please review this PR whenever you are free?
Thanks for your kindness 🙏

takahirom · 2024-09-07T13:47:09Z

@nyafunta9858 It might be a little confusing when we introduce the app-desktop module with the Hello KaigiApp text. Could you connect one screen, for example, the contributor screen? This might be good for confirming the technology. I think this PR is still small and fine.

takahirom · 2024-09-08T02:45:43Z

I think we can create a feature branch for this. Once it works with one screen, I would like to merge it into the main branch. Thank you for investigating KMP possibilities. I'll merge this into the feature branch.

nyafunta9858 added 6 commits August 12, 2024 16:39

The first commit of app-desktop, only saying Hello

43d57ff

Merge branch 'DroidKaigi:main' into feature/300-app-desktop

3e0df69

Update JetBrains Compose Plugin's version to resolve java.lang.Unsati…

607adcf

…sfiedLinkError that was caused to import Navigation Compose to app-desktop, made with compose multiplatform.

Rename main class from MainKt to MainApplicationKt

9741de3

Import design system module to app-desktop and adapt its theme

54a7819

Merge remote-tracking branch 'origin/main' into feature/300-app-desktop

5a4e4e5

nyafunta9858 commented Aug 14, 2024

View reviewed changes

github-actions bot temporarily deployed to deploygate-distribution August 14, 2024 15:51 Inactive

add a comment

4218ab3

nyafunta9858 commented Aug 15, 2024

View reviewed changes

nyafunta9858 added 2 commits August 15, 2024 23:50

Revert definitions to apply plugins

8364a30

Add actual method that was added when merge from main branch

f3ab59e

nyafunta9858 changed the title ~~[WIP] Add app-desktop module~~ Add app-desktop module Aug 15, 2024

nyafunta9858 marked this pull request as ready for review August 15, 2024 15:09

nyafunta9858 mentioned this pull request Aug 15, 2024

Add app-desktop module for faster development #300

Open

github-actions bot temporarily deployed to deploygate-distribution August 16, 2024 01:32 Inactive

takahirom added the Waiting for response or commit label Aug 16, 2024

Add compose.desktop.packaging.checkJdkVendor=false to gradle.properti…

2b81c43

…es for building packageDmg

github-actions bot removed the Waiting for response or commit label Aug 16, 2024

github-actions bot temporarily deployed to deploygate-distribution August 16, 2024 05:53 Inactive

fix detekt

331327c

github-actions bot temporarily deployed to deploygate-distribution August 16, 2024 07:23 Inactive

Merge branch 'main' into feature/300-app-desktop

0ebae38

github-actions bot temporarily deployed to deploygate-distribution August 16, 2024 08:03 Inactive

Merge branch 'main' into feature/300-app-desktop

b1f3452

github-actions bot temporarily deployed to deploygate-distribution August 18, 2024 07:48 Inactive

nyafunta9858 added 3 commits August 24, 2024 23:44

Remove the dependencies to navigation compose from desktop app module.

6345f98

Merge remote-tracking branch 'refs/remotes/origin/feature/300-app-des…

1b854b3

…ktop' into feature/300-app-desktop

Merge branch 'main' into feature/300-app-desktop

d5ee8a4

github-actions bot temporarily deployed to deploygate-distribution August 25, 2024 00:27 Inactive

Merge remote-tracking branch 'origin/main' into feature/300-app-desktop

d9e6907

nyafunta9858 added 3 commits September 7, 2024 20:28

Merge branch 'main' into feature/300-app-desktop

1e99748

Resolve a crash immediately after launch the desktop app.

6b433cd

Optimize dependencies on KmpDesktopPlugin

4eea845

github-actions bot temporarily deployed to deploygate-distribution September 7, 2024 12:09 Inactive

takahirom changed the base branch from main to app-desktop September 8, 2024 02:43

takahirom merged commit 7742e5f into DroidKaigi:app-desktop Sep 8, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add app-desktop module #452

Add app-desktop module #452

nyafunta9858 commented Aug 14, 2024 •

edited

Loading

nyafunta9858 Aug 14, 2024 •

edited

Loading

nyafunta9858 Aug 14, 2024 •

edited

Loading

nyafunta9858 Aug 15, 2024

nyafunta9858 Aug 15, 2024

github-actions bot commented Aug 16, 2024

takahirom commented Aug 16, 2024

nyafunta9858 commented Aug 16, 2024 •

edited

Loading

takahirom commented Aug 16, 2024

nyafunta9858 commented Aug 16, 2024 •

edited

Loading

takahirom commented Aug 17, 2024 •

edited

Loading

nyafunta9858 commented Aug 17, 2024 •

edited

Loading

nyafunta9858 commented Aug 17, 2024 •

edited

Loading

nyafunta9858 commented Aug 19, 2024 •

edited

Loading

nyafunta9858 commented Aug 24, 2024 •

edited

Loading

takahirom commented Sep 6, 2024

nyafunta9858 commented Sep 7, 2024

takahirom commented Sep 7, 2024

nyafunta9858 commented Sep 7, 2024

takahirom commented Sep 7, 2024

takahirom commented Sep 8, 2024

Add app-desktop module #452

Add app-desktop module #452

Conversation

nyafunta9858 commented Aug 14, 2024 • edited Loading

Issue

Overview (Required)

Links

Movie (Optional)

Notes

nyafunta9858 Aug 14, 2024 • edited Loading

Choose a reason for hiding this comment

nyafunta9858 Aug 14, 2024 • edited Loading

Choose a reason for hiding this comment

nyafunta9858 Aug 15, 2024

Choose a reason for hiding this comment

nyafunta9858 Aug 15, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 16, 2024

takahirom commented Aug 16, 2024

nyafunta9858 commented Aug 16, 2024 • edited Loading

takahirom commented Aug 16, 2024

nyafunta9858 commented Aug 16, 2024 • edited Loading

takahirom commented Aug 17, 2024 • edited Loading

nyafunta9858 commented Aug 17, 2024 • edited Loading

nyafunta9858 commented Aug 17, 2024 • edited Loading

nyafunta9858 commented Aug 19, 2024 • edited Loading

nyafunta9858 commented Aug 24, 2024 • edited Loading

takahirom commented Sep 6, 2024

nyafunta9858 commented Sep 7, 2024

takahirom commented Sep 7, 2024

nyafunta9858 commented Sep 7, 2024

takahirom commented Sep 7, 2024

takahirom commented Sep 8, 2024

nyafunta9858 commented Aug 14, 2024 •

edited

Loading

nyafunta9858 Aug 14, 2024 •

edited

Loading

nyafunta9858 Aug 14, 2024 •

edited

Loading

nyafunta9858 commented Aug 16, 2024 •

edited

Loading

nyafunta9858 commented Aug 16, 2024 •

edited

Loading

takahirom commented Aug 17, 2024 •

edited

Loading

nyafunta9858 commented Aug 17, 2024 •

edited

Loading

nyafunta9858 commented Aug 17, 2024 •

edited

Loading

nyafunta9858 commented Aug 19, 2024 •

edited

Loading

nyafunta9858 commented Aug 24, 2024 •

edited

Loading