Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test github token #31931

Merged
merged 13 commits into from
Nov 16, 2024
Merged

test github token #31931

merged 13 commits into from
Nov 16, 2024

Conversation

frederic34
Copy link
Member

@frederic34 frederic34 commented Nov 15, 2024

@eldy I reactivate action on pull request
this action calculate how many errors are ignored, if the number decrease it update the baseline

@frederic34
Copy link
Member Author

image

@frederic34
Copy link
Member Author

if it works, you can also run the workflow manually to clean the phpstan baseline

@frederic34
Copy link
Member Author

frederic34 commented Nov 15, 2024

action to clean caches is also in error
image

image

@eldy
Copy link
Member

eldy commented Nov 16, 2024

image

Why having the pho baseline run at each pr ? Why not doing it only once a week or day to avoid overload of github action on our repo ?

1 similar comment
@eldy
Copy link
Member

eldy commented Nov 16, 2024

image

Why having the pho baseline run at each pr ? Why not doing it only once a week or day to avoid overload of github action on our repo ?

@frederic34
Copy link
Member Author

@eldy this task is also sheduled, here you can see it don't work https://github.com/Dolibarr/dolibarr/actions/runs/11831647690/job/32967144876
ok to not run on pull_request, i have no other way to test

@eldy eldy merged commit c496df7 into Dolibarr:develop Nov 16, 2024
6 checks passed
@frederic34 frederic34 deleted the test_actions_github_token branch November 16, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants