Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Add a workflow to let @lvessiller-opendsi and @rycks merge 18.0 PR by accepting reviews #31898

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

fcharlaix-opendsi
Copy link
Contributor

@fcharlaix-opendsi fcharlaix-opendsi commented Nov 15, 2024

The workflow only run on PR targeting the 18.0 branch, it adds @lvessiller-opendsi and @rycks as assignee and reviewer.

Combine with the ruleset below and allowing auto merge on this repo, the PR will auto merge once all requirements are met.

This ruleset make two approved review a requirement for all PR on 18.0 (excepted for repo admin) :

{
  "id": 2630207,
  "name": "18",
  "target": "branch",
  "source_type": "Repository",
  "source": "fcharlaix-opendsi/dolibarr",
  "enforcement": "active",
  "conditions": {
    "ref_name": {
      "exclude": [],
      "include": [
        "refs/heads/18.0"
      ]
    }
  },
  "rules": [
    {
      "type": "deletion"
    },
    {
      "type": "non_fast_forward"
    },
    {
      "type": "pull_request",
      "parameters": {
        "required_approving_review_count": 2,
        "dismiss_stale_reviews_on_push": true,
        "require_code_owner_review": false,
        "require_last_push_approval": false,
        "required_review_thread_resolution": true,
        "automatic_copilot_code_review_enabled": false
      }
    }
  ],
  "bypass_actors": [
    {
      "actor_id": 5,
      "actor_type": "RepositoryRole",
      "bypass_mode": "always"
    }
  ]
}

@fcharlaix-opendsi fcharlaix-opendsi changed the title New Add a workflow to let @lvessiller-opendsi and @crycks merge 18.0 PR by accepting reviews New Add a workflow to let @lvessiller-opendsi and @rycks merge 18.0 PR by accepting reviews Nov 15, 2024
@frederic34
Copy link
Member

this action tries to clean the phpstan baseline, but I can get github token
https://github.com/Dolibarr/dolibarr/actions/workflows/phpstan_baseline.yml
Is it desactivated in repo settings ?

@eldy
Copy link
Member

eldy commented Nov 15, 2024

this action tries to clean the phpstan baseline, but I can get github token
@frederic34
What do you mean with "this action tries to clean the phpstan baseline, but I can get github token" ?

@frederic34
Copy link
Member

@eldy #31931

@eldy
Copy link
Member

eldy commented Nov 16, 2024

@eldy #31931

31931 is related to phpstan_baseline.xml action. But this pr is related to another action to auto assign 2 users on any pr on branch v18.
The 31931 has a pb to get token (but i don't know why), but i don't see the relation whis this pr #31898 that is in branch 18.
Did i miss something ?

@eldy eldy merged commit f2f3e47 into Dolibarr:18.0 Nov 18, 2024
3 checks passed
@frederic34 frederic34 mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants