Qual: "Backport phan to 18.0" prepare develop branch

.github/workflows/ci.yml

@@ -35,6 +35,6 @@ jobs:
 
 
 # Note (not tested, from https://github.com/orgs/community/discussions/38361)
-# To cancel jobs if one failes, the following action may help
+# To cancel jobs if one fails, the following action may help
 #       - if: "failure()"
 #        uses: "andymckay/[email protected]"

.github/workflows/pre-commit.yml

@@ -142,3 +142,4 @@ jobs:
           path: |
             ${{ env.RAW_LOG }}
             ${{ env.CS_XML }}
+            retention-days: 2

.pre-commit-config.yaml

@@ -39,6 +39,8 @@ repos:
       # Remove trailing whitespace
       - id: trailing-whitespace
         exclude_types: [markdown]
+        exclude: |
+          (?x)^(dev/tools/codespell/codespell-lines-ignore.txt)$
       # Fix the end of file
       - id: end-of-file-fixer
       # Check that there are no completely merged file conflicts
@@ -227,7 +229,18 @@ repos:
           - dev/tools/codespell/codespell-lines-ignore.txt
           - --uri-ignore-words-list
           - ned
-
+      - alias: codespell-ignores
+        #
+        # Update codespell ignore file.
+        #
+        # Execute with `pre-commit run codespell-ignores -a --hook-stage manual`
+        id: codespell
+        stages: [manual]
+        name: Update file with codespell exceptions
+        additional_dependencies: [tomli]
+        language: python
+        entry: bash -c '[ ! -x dev/tools/codespell/addCodespellIgnores.sh ] || dev/tools/codespell/addCodespellIgnores.sh'
+        pass_filenames: false
   # Check some shell scripts
   - repo: https://github.com/shellcheck-py/shellcheck-py
     rev: v0.10.0.1

dev/tools/phan/config.php

@@ -344,7 +344,7 @@
 		'/^GETPOST$/' => [1, $sanitizeRegex, 'GetPostUnknownSanitizeType'],
 		'/^isModEnabled$/' => [0, $moduleNameRegex, 'UnknownModuleName'],
 		// Note: trick to have different key for same regex:
-		'/^isModEnable[d]$/' => [0, $deprecatedModuleNameRegex, "DeprecatedModuleName"],
+		// '/^isModEnable[d]$/' => [0, $deprecatedModuleNameRegex, "DeprecatedModuleName"],
 		'/^sanitizeVal$/' => [1, $sanitizeRegex,"UnknownSanitizeType"],
 		'/^checkVal$/' => [1, $sanitizeRegex,"UnknownCheckValSanitizeType"],
 		'/^\\\\ExtraFields::addExtraField$/' => [2, $extraFieldTypeRegex,"UnknownExtrafieldTypeBack"],

htdocs/product/price_suppliers.php

@@ -1258,7 +1258,7 @@ function edit_price_from_multicurrency() {
 						// Date modification
 						if (!empty($arrayfields['pfp.tms']['checked'])) {
 							print '<td class="right nowraponall">';
-							print dol_print_date(($productfourn->fourn_date_modification ? $productfourn->fourn_date_modification : $productfourn->date_modification), "dayhour");
+							print dol_print_date(($productfourn->fourn_date_modification ? $productfourn->fourn_date_modification : $productfourn->date_modification), 'dayhour', 'tzuserrel');
 							print '</td>';
 						}