Qual: "Backport phan to 18.0" prepare develop branch #30616
Conversation
mdeweerd
changed the title
mdeweerd
changed the title
./.github/workflows/gh-travis.yml is included and inactive, but it must exist for ci.yml. To keep ci.yml the same accross versions, gh-travis.yml is included.
|
Old versions are versions already released and open for bug fix and only bug fix maintenance, as we must reduce as much as possible the printing of any change on maintenance versions. So code quality on already released version is not necessary so we can be more focused on develop branch. |
|
@eldy This is not about "fixing" what is already not ok in the older versions, it's about fixing what is added in changes. Once in the develop version, ci can be stuck for quite a long time. All the existing notices are excluded, so only new ones are excluded. N-2 is the recommended bug fix release, so that is a logical backport for the flow.
So other verifications could also be inhibited: spelling checks for instance. But I do not believe that inhibiting is the best approach. |
Qual: "Backport phan to 18.0" prepare develop branch
The goal is integration in 18.0 and 19.0 as phan is already setup in 20.0, but this PR is to make it "seamless" to backport to 18.0 and 19.0.
It must be merged after the "empty" PR to develop which needs to be integrated first.
By following that order, the upward path (from 18.0 to 19.0 to 20.0 to develop) should be flawless, without any merge issues for the changes related to phan.
However, do not make a squash merge to make sure the history is understood by git.