Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(threads): move runtime import required for Thread.permissions_for #1124

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

shiftinv
Copy link
Member

Summary

Fixes #1123.

In the future, we should look into enabling https://docs.astral.sh/ruff/rules/#flake8-type-checking-tch to catch these earlier. Historically those rules have been rather buggy, but they might be more mature now.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added this to the disnake v2.10 milestone Oct 19, 2023
@shiftinv shiftinv merged commit 857dd2d into master Oct 19, 2023
29 checks passed
@shiftinv shiftinv deleted the fix/thread-permissions-for-import branch October 19, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug in threads.py
1 participant