Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint): enable ruff TCH (flake8-type-checking) rules #1125

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

shiftinv
Copy link
Member

Summary

Enables ruff's TCH rules (flake8-type-checking) -- see #1124.

TCH001-TCH003 are left disabled for now, since those are not trivial to take care of in some places. The important one in our case is TCH004 anyway.

The code changes in this PR are to satisfy the new rules, they weren't actual issues (unlike #1124). As mentioned, TCH004 isn't perfect and has a couple edge cases, particularly when it comes to submodule imports.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: refactor/typing/lint Refactors, typing changes and/or linting changes skip news labels Oct 23, 2023
@shiftinv shiftinv added this to the disnake v2.10 milestone Oct 23, 2023
@shiftinv shiftinv changed the title lint: enable ruff TCH (flake8-type-checking) rules feat(lint): enable ruff TCH (flake8-type-checking) rules Oct 23, 2023
@shiftinv shiftinv merged commit ffb7526 into master Oct 26, 2023
30 of 31 checks passed
@shiftinv shiftinv deleted the lint/ruff-type-checking branch October 26, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news t: enhancement New feature t: refactor/typing/lint Refactors, typing changes and/or linting changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant