feat(lint): enable ruff TCH
(flake8-type-checking) rules
#1125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enables ruff's
TCH
rules (flake8-type-checking) -- see #1124.TCH001
-TCH003
are left disabled for now, since those are not trivial to take care of in some places. The important one in our case isTCH004
anyway.The code changes in this PR are to satisfy the new rules, they weren't actual issues (unlike #1124). As mentioned,
TCH004
isn't perfect and has a couple edge cases, particularly when it comes to submodule imports.Checklist
pdm lint
pdm pyright