-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update pyright to v1.1.336 #1122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftinv
added
s: needs review
Issue/PR is awaiting reviews
t: dependencies
Addition/update/removal of dependencies
t: refactor/typing/lint
Refactors, typing changes and/or linting changes
labels
Oct 19, 2023
8 tasks
shiftinv
force-pushed
the
deps/pyright-update
branch
from
November 4, 2023 20:58
a214032
to
f088d83
Compare
shiftinv
changed the title
build(deps): update pyright to v1.1.332
build(deps): update pyright to v1.1.336
Nov 15, 2023
…ers `TypedDict.update` properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
s: needs review
Issue/PR is awaiting reviews
skip news
t: dependencies
Addition/update/removal of dependencies
t: refactor/typing/lint
Refactors, typing changes and/or linting changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This has been long overdue, and fixes the ~140 typing issues that have popped up in new versions since then.
Almost all changes are internal, with only a few that affect public interfaces:
type
s of components are nowLiteral[ComponentType.xyz]
, instead of justComponentType
.AssetBytes
union now explicitly supportsbytearray
andmemoryview
; pre-PEP688, these were implied by thebytes
type.Checklist
pdm lint
pdm pyright