Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update pyright to v1.1.336 #1122

Merged
merged 16 commits into from
Nov 17, 2023
Merged

build(deps): update pyright to v1.1.336 #1122

merged 16 commits into from
Nov 17, 2023

Conversation

shiftinv
Copy link
Member

Summary

This has been long overdue, and fixes the ~140 typing issues that have popped up in new versions since then.
Almost all changes are internal, with only a few that affect public interfaces:

  • The types of components are now Literal[ComponentType.xyz], instead of just ComponentType.
  • The AssetBytes union now explicitly supports bytearray and memoryview; pre-PEP688, these were implied by the bytes type.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added s: needs review Issue/PR is awaiting reviews t: dependencies Addition/update/removal of dependencies t: refactor/typing/lint Refactors, typing changes and/or linting changes labels Oct 19, 2023
@shiftinv shiftinv added this to the disnake v2.10 milestone Oct 19, 2023
@shiftinv shiftinv force-pushed the deps/pyright-update branch from a214032 to f088d83 Compare November 4, 2023 20:58
@shiftinv shiftinv changed the title build(deps): update pyright to v1.1.332 build(deps): update pyright to v1.1.336 Nov 15, 2023
@shiftinv shiftinv merged commit 4bd0d25 into master Nov 17, 2023
27 checks passed
@shiftinv shiftinv deleted the deps/pyright-update branch November 17, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: needs review Issue/PR is awaiting reviews skip news t: dependencies Addition/update/removal of dependencies t: refactor/typing/lint Refactors, typing changes and/or linting changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant