feat(commands): support 3.12's type statement and TypeAliasType
#1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for this is that GenericAlias proxies its `__origin__`'s attributes; if we have a GenericAlias with a TypeAliasType `__origin__`, `hasattr(tp, "__value__")` will match even though we're really looking at a GenericAlias.
shiftinv
added
t: enhancement
…solving TypeAliasType see previous commit for tests
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(most of the recent typing-related commits were a prerequisite for this; #1122 is the one remaining blocker for this, afaict)
This change adds support for type annotations declared using the
typestatement from PEP 695; the deferred evaluation is really quite neat for users, but it made evaluating signatures a bit more tricky, especially when you throw forwardrefs into the mix.Checklist
pdm lintpdm pyright