Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default the perl interpreter to the first one in $PATH... #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

isu-rassilon
Copy link

...using the 'env' command. Previously, each file specified something like /usr/bin/perl, /usr/local/bin/perl, /u1/local/bin/perl, /tools/bin/perl, etc.

…local/sbin:/usr/bin:/usr/sbin:/bin:/sbin:/home/rassilon/.composer/vendor/bin:/home/rassilon/.local/bin:/home/rassilon/bin using the 'env' command. Previously, each file specified something like /usr/bin/perl, /usr/local/bin/perl, /u1/local/bin/perl, /tools/bin/perl, etc.
@isu-rassilon
Copy link
Author

@rmhubley Sorry, I forgot to tag you for review.

@rmhubley
Copy link
Member

I have avoided doing this because of dependency checking. The configure script takes care of performing perl module dependency checking prior to setting the interpreter at the top of each script. So, in a sense the first line of these scripts could be anything to begin with.

@isu-rassilon
Copy link
Author

Sure, you expect the configuration script to be run, but that doesn't happen when this is installed via Spack (https://spack.io/) for a HPC environment. In that case, using "/usr/bin/env perl" is basically required.

Also, if the configuration script rewrites the first line during normal usage, why is changing the interpreter to be consistent a problem?

@@ -1,4 +1,4 @@
#!/usr/local/bin/perl -w
#!/usr/bin/env perl -w
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line and all others in the modules (*.pm) should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants