Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Spanish translation #39

Open
wants to merge 1 commit into
base: refactor1
Choose a base branch
from
Open

Added Spanish translation #39

wants to merge 1 commit into from

Conversation

corp-0
Copy link

@corp-0 corp-0 commented Jan 11, 2019

Hey! This is my first pull request ever so forgive me if I did something wrong.

I added Spanish translation to stringtable.xml, doing a pull request in this branch because I guess this is the most recent and in development (?).

Let me know if I did wrong so I can get better in this github thing.

@DerZade DerZade self-assigned this Jan 11, 2019
@DerZade
Copy link
Owner

DerZade commented Jan 11, 2019

Thanks a lot for the Spanish translation.
No need to apologize 😄 people, who want to contribute, are always welcome. 🤗

The PR looks fine to me.

I'll merge once I'm ready to release the new update, although this will probably take a while because I'm waiting for a command to (hopefully) be implemented into the game ^^

I hope that's okay for you 😃

@DerZade DerZade self-requested a review January 11, 2019 09:00
@corp-0
Copy link
Author

corp-0 commented Jan 11, 2019

The PR looks fine to me.

Yeah, what I meant was if it is ok to PR in this branch or should I use master instead. I see most of the people doing PR on master but I guess that's the stable version and thus shouldn't be modified until merged with the branch in development when is done(?)

I'll merge once I'm ready to release the new update, although this will probably take a while because I'm waiting for a command to (hopefully) be implemented into the game ^^
I hope that's okay for you 😃

Sure thing, you're the boss.

Should I close the PR myself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants