-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mole: Remove the dependency for decimal.js and remove Aptos #11098
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8146496
add Mole tvl on Sui chain
molefund 0ddb2b4
Move decimal.js to local
molefund 048de90
Remove the dependency for decimal.js and rm Aptos
molefund 5f5281b
Merge branch 'main' into main
molefund 5e8a80f
Merge branch 'DefiLlama:main' into main
molefund b804e98
Merge branch 'DefiLlama:main' into main
molefund 5191de7
Keep Mole TVL in Aptos
molefund 16889b6
Merge branch 'main' of https://github.com/Mole-Fi/DefiLlama-Adapters
molefund 7c01979
Merge pull request #1 from DefiLlama/main
molefund File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this value represent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @g1nt0ki , thanks for the review. This value represent the borrowed part in Mole savings vaults. It is a mistake we didn't add it up before. It is a fixing for vaults value. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but the borrowed tokens dont leave the platform but are used as LP and you are already adding LP value right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @g1nt0ki , thank you for your review.
For the vault_debt_val, sorry that it may cause some misunderstanding. It is mToken value staked in Mole fairlauch. It was missing before. It is actually should be taken into calculated in the Mole savings vaults vaule.
For the Aptos chain TVL, if it should be kept for history tracking purpose, I'll submit a code fix later that keep Mole in Aptos TVL.