-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mole: Remove the dependency for decimal.js and remove Aptos #11098
Conversation
The adapter at projects/mole exports TVL:
|
The adapter at projects/mole exports TVL:
|
for (let i = 0; i < vaultInfos.length; i++) { | ||
const baseToken = addresses.Vaults[i].baseToken | ||
const tokenAmount = vaultInfos[i].fields.value.fields.coin | ||
api.add(baseToken, tokenAmount) | ||
const vaultDebtVal = vaultInfos[i].fields.value.fields.vault_debt_val |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this value represent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @g1nt0ki , thanks for the review. This value represent the borrowed part in Mole savings vaults. It is a mistake we didn't add it up before. It is a fixing for vaults value. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but the borrowed tokens dont leave the platform but are used as LP and you are already adding LP value right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @g1nt0ki , thank you for your review.
-
For the vault_debt_val, sorry that it may cause some misunderstanding. It is mToken value staked in Mole fairlauch. It was missing before. It is actually should be taken into calculated in the Mole savings vaults vaule.
-
For the Aptos chain TVL, if it should be kept for history tracking purpose, I'll submit a code fix later that keep Mole in Aptos TVL.
@molefund thanks for the PR we cant remove aptos tvl, it will affect aptos chain tvl history, and imo, it was a mistake to remove avax, unsure why we did it at that time. |
The adapter at projects/mole exports TVL:
|
Thank you for the review. Mole has been on Avax and Aptos before. But the TVL of Mole on these two chains are almost zero. So we remove it from Avax and Aptos. |
"But the TVL of Mole on these two chains are almost zero" yes, but we still would like to show aptos as it used to have tvl |
The adapter at projects/mole exports TVL:
|
Sync from main
The adapter at projects/mole exports TVL:
|
Thank you @g1nt0ki , I have submitted a fix that keep Mole in Aptos TVL |
merged here: #11212 |
Dear DefiLlama, this pull request is to update the existing project code for Mole. We have removed the dependency for decimal.js , in order to keep a clean package.json . Also we have removed the Aptos tvl in this change. Could you please help to review and approve it? Thank you so much